Repository navigation
π fix(stories): copy the full story to the clipboard, trim only the issue URL - #261
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Read the full dialog script in stories/index.html at a7932b9, not just the diff. This looks correct to me.
collectData()(stories/index.html:424-435) now keeps bothstory(thetruncateStory()cut used bybuildIssue()for the URL, line 414) andstory_full(rawgetValue("story-text"), line 431) βmarkdown()at line 399 is the only consumer ofstory_full, andbuildIssue()still only readsdata.story, so the issues/new URL stays capped at 1500 chars as before.- The "Copy issue text carries the full story." suffix is added only on the popup-blocked branch (line 512). That is the right scope:
#story-copylives inside#story-fallback(lines 278-281), which is hidden on the popup-opened path, so the opened-tab notice (line 518) correctly stays unchanged. - Recomputed the sha256 of the inline script at the PR head:
fqaSlc/mYehO2SKM+k6zUFkHrNm5dXfP1C6LhHKcToQ=, matching the new CSPscript-srchash on line 5. node --test scripts/story-dialog.test.mjsβ 29/29 pass locally, including the new truncated+copy case, which pins the exact gap #260 describes.
Matches the issue's stated expectation (cap is URL-only; clipboard untrimmed). Nothing blocking from my side.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read stories/index.html at a7932b9 and ran the suite β looks correct to me.
collectData()(stories/index.html:431) now keepsstory_fullfromgetValue("story-text")alongside the cappedstory;markdown()(:399) emitsstory_full, whilebuildIssue()(:419) still puts the cappeddata.storyin theissues/newURL β so only the URL is trimmed, matching #260.trimmedNotice(:508) ends with a trailing space, so the appended"Copy issue text carries the full story."reads cleanly.- CSP:
node --test scripts/page-csp.test.mjs scripts/story-dialog.test.mjsβ 59/59 pass, so the refreshedscript-srchash matches the edited inline script.
No findings. (I have not approved β that's a human's call.)
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Closes #260
The 1500-character cap exists only to keep the prefilled issues/new URL short; the clipboard fallback has no such limit, so
Copy issue textnow carries the untrimmed story and the trimmed-story notice says so. Adds a story-dialog self-test for popup-blocked + >1500-char story and refreshes the CSP script hash.β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88