Skip to content

πŸ› fix(stories): copy the full story to the clipboard, trim only the issue URL - #261

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-260
Oct 25, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-260

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #260

The 1500-character cap exists only to keep the prefilled issues/new URL short; the clipboard fallback has no such limit, so Copy issue text now carries the untrimmed story and the trimmed-story notice says so. Adds a story-dialog self-test for popup-blocked + >1500-char story and refreshes the CSP script hash.

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 25, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the full dialog script in stories/index.html at a7932b9, not just the diff. This looks correct to me.

  • collectData() (stories/index.html:424-435) now keeps both story (the truncateStory() cut used by buildIssue() for the URL, line 414) and story_full (raw getValue("story-text"), line 431) β€” markdown() at line 399 is the only consumer of story_full, and buildIssue() still only reads data.story, so the issues/new URL stays capped at 1500 chars as before.
  • The "Copy issue text carries the full story." suffix is added only on the popup-blocked branch (line 512). That is the right scope: #story-copy lives inside #story-fallback (lines 278-281), which is hidden on the popup-opened path, so the opened-tab notice (line 518) correctly stays unchanged.
  • Recomputed the sha256 of the inline script at the PR head: fqaSlc/mYehO2SKM+k6zUFkHrNm5dXfP1C6LhHKcToQ=, matching the new CSP script-src hash on line 5.
  • node --test scripts/story-dialog.test.mjs β†’ 29/29 pass locally, including the new truncated+copy case, which pins the exact gap #260 describes.

Matches the issue's stated expectation (cap is URL-only; clipboard untrimmed). Nothing blocking from my side.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 78adc80 into main Oct 25, 2026
6 of 7 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-260 branch October 25, 2026 08:19
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#261a7932b9` sha256:37a2574befe9fa8f878e284802a48c74dc3df74f0bcd92665b9b4edeac34144c β€” download from the dashboard or `hivectl review evidence #261`.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read stories/index.html at a7932b9 and ran the suite β€” looks correct to me.

  • collectData() (stories/index.html:431) now keeps story_full from getValue("story-text") alongside the capped story; markdown() (:399) emits story_full, while buildIssue() (:419) still puts the capped data.story in the issues/new URL β€” so only the URL is trimmed, matching #260.
  • trimmedNotice (:508) ends with a trailing space, so the appended "Copy issue text carries the full story." reads cleanly.
  • CSP: node --test scripts/page-csp.test.mjs scripts/story-dialog.test.mjs β†’ 59/59 pass, so the refreshed script-src hash matches the edited inline script.

No findings. (I have not approved β€” that's a human's call.)

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] stories: 'Copy issue text' fallback trims the story to 1500 chars though only the URL needs the cap

0 participants