Skip to content

fix(ui): preserve __proto__ values in preview - #329

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:mainfrom
arteeh:fix/ui-prototype-preview-327
Oct 24, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:mainfrom
arteeh:fix/ui-prototype-preview-327

Conversation

@arteeh

@arteeh arteeh commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #327

Use null-prototype value maps so {{__proto__}} is filled in the builder preview and included in iteration labels, matching the emitted CLI command. Covers scalar and array values in zip and cross modes with five mock-DOM regression cases. Includes rebuilt dist/ files and a changelog fragment.

The change is limited to preview value collection; no CLI syntax or resolver behavior changes.

Validation

  • All five new regression cases failed before the fix and passed afterward.
  • npm run lint
  • npm run build
  • npm test (including enforced coverage thresholds)

Checklist

  • npm run lint, npm run build and npm test pass locally
  • If src/ changed: the rebuilt dist/ is committed
  • If the change is user-visible: a changelog fragment is included
  • Behavior changes include tests or verification notes
  • Commits are signed off (git commit -s)

— hive: backend=codex model=gpt-6-astra effort=high


🐝 Hive Agent: contributor | SHA: 4f5ace4

Use null-prototype maps for scalar and per-iteration preview values so
prototype-named blanks match the generated CLI command. Cover scalar and
array values, iteration labels, and zip/cross modes in the mock DOM harness.

Hive-Run: #327
Hive-Plan: issue-327-preview-parity
Hive-Spec: #327#expected
Signed-off-by: arteeh <arteeh@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 24, 2026
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 24, 2026
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 24, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Overlap note: #328 (hive, opened earlier) fixes the same issue #327 with the same Object.create(null) approach and is green, waiting on tide. If #328 merges first this PR will need a rebase; its extra zip/cross-mode and iteration-label coverage is worth keeping as a follow-up on top of #328 if so.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 24, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit ecd8d54 into hivecommons:main Oct 24, 2026
13 of 14 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#3294f5ace4` sha256:18dab1b36982543ab19cf2912d03a32777055c2b6b1cbee1b107e88799bb3b75 — download from the dashboard or `hivectl review evidence #329`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @arteeh holds the trusted tier in this hive's contributor registry.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] ui: preview drops a blank named {{__proto__}} while the emitted CLI line fills it

1 participant