[hivecommons-hive]

A ** glob segment now matches zero or more directory levels (skipping dot-directories and symlinked directories, tolerating unreadable dirs) instead of exactly one. Adds tests, README row, changelog fragment, and hand-mirrored dist/ output (source maps not regenerated).

Closes #336

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hivecommons-hive]

hive/awaiting-ci: CI pending — sweep will merge when green.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

The code change is correct; the only thing blocking this PR is that the hand-mirrored dist/ output does not match what tsc emits, so the Check committed dist/ is in sync with src/ gate fails on all six build-and-test jobs (the Test step is skipped, so the red is not a test failure).

I checked out dac35ac, ran npm ci && npm run build, and git status --porcelain -- dist/ reports three modified files:

• dist/resolver.test.js — the hand-written mirror has blank lines between the four new it(...) blocks (lines 150, 157, 166, 173); tsc strips them.
• dist/resolver.js.map and dist/resolver.test.js.map — not regenerated (the PR body says so). The gate diffs these too.

Fix is one commit: npm run build && git add dist && git commit. Nothing else needs to change.

What I verified in src/resolver.ts:

• descendantDirs (lines 74–88) uses Dirent.isDirectory(), which is false for symlinks, so symlinked dirs are skipped and recursion cannot cycle. Unreadable dirs return [] via the try/catch. Dot-dirs are skipped, consistent with the existing * branch at line 110.
• The ** branch (lines 98–101) pushes base itself plus every descendant, giving the "zero or more levels" semantics; the segments[i + 1] === '**' guard collapses a/**/**/b without touching bases.
• When nothing matches, bases ends empty and expandPiece (line 25) falls back to the literal — covered by the new "keeps a non-matching ** pattern literal" test.
• npm test on the branch: all passing, resolver.js 99.01% lines (the two uncovered lines are the unreadable-dir catch at 64–65).

README row and changelog.d/fixed-336.md match the behaviour; fragment name follows the fixed-<pr-or-slug>.md convention.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

hive/awaiting-ci: CI pending — sweep will merge when green. (Pushed regenerated dist/ for the dist-sync gate.)

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: f40af41

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read src/resolver.ts at f40af41 plus the callers (expandPiece → expandGlob) and the existing */? segment path; this looks correct to me.

What I verified:

• src/resolver.ts:99-102 — the ** branch pushes each current base and its descendants, so ** matches zero or more levels (a.go, x/b.go, x/y/c.go in the test). The continue for consecutive ** (:100) leaves bases untouched, so a/**/**/b behaves as one **.
• src/resolver.ts:74-88 — descendantDirs uses withFileTypes, so isDirectory() is false for symlinked dirs: no symlink-loop recursion. Unreadable dirs return [] rather than throwing, matching the existing readdirSync try/catch at :113-117.
• A relative pattern (**/*.go) starts from base '', which both branches already map to . (:78, :115).
• Non-matching ** patterns still fall through if (bases.length === 0) break and are kept literal by the caller (covered by the new test).
• Rebuilt dist/ locally from this head: git status --porcelain -- dist/ is empty, so the hand-mirrored output matches the compiler. All tests pass, including the four new ** cases.

One note, not a defect: a trailing ** (dir/**) yields only directories, not files (test at src/resolver.test.ts:224-231 pins this). Bash globstar would also list files. The README row says "matches any depth", which is true either way — just flagging in case a maintainer wants file-inclusive semantics later.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read src/resolver.ts at f40af41 and the callers in expandPiece; this looks correct to me.

• expandGlob (src/resolver.ts:90-128): the new ** branch pushes each base plus descendantDirs(base), so zero levels are covered (the a.go case from #336) and the existing */? branch is untouched. descendantDirs uses withFileTypes + isDirectory(), which is false for symlinks, so symlinked dirs are not followed; unreadable dirs return []. Consecutive ** collapse via the segments[i+1] === '**' skip, and the new Set dedupe covers ..-normalised collisions.
• Non-match fallback is unchanged: bases goes empty → expandPiece returns the literal (covered by the new "keeps a non-matching ** pattern literal" test).
• Rebuilt dist/ with tsc from the PR head: git status --porcelain -- dist/ is empty, so the committed output (including the .map files the body says were not regenerated) is byte-identical to a real build. Full suite: 472/472 pass.

One note, not a defect: a trailing ** (dir/**) yields directories only (src/resolver.ts:99), whereas bash globstar/minimatch also yield files. #336 does not specify this, and the test pins the current behaviour, so it is a documented choice rather than a bug — worth a word in the README row if anyone passes --file=dir/** expecting files.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Evidence bundle `#337f40af41` sha256:5354d317b98e35bc423c659868310dc3e6ce1561a69cf34b57567160b916409f — download from the dashboard or `hivectl review evidence #337`.

[github-actions]

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback