Repository navigation
🌱 test(sanitize): pin each stripTerminalEscapes recogniser with a direct assertion - #411
Merged
Merged
Conversation
…ect assertion The nightly advisory Stryker run left 8 mutants alive in sanitize.ts, 7 of them Regex mutants on the DCS, charset-designation, keypad-mode, generic two-byte ESC and C0/C1 sweep patterns. The existing sanitizeForTerminal tests only assert that the ESC byte is gone; because the final control-char sweep removes a stray ESC anyway, a broken recogniser leaks the sequence's payload or final byte without failing a test. Each new case feeds one recogniser an input only it consumes whole and asserts the exact output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/M
hivecommons-hive
Bot
added
author/hive
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Looks correct to me — test-only, and the tests do what they claim.
What I verified at 2258b6b:
- Read
src/sanitize.ts:44-62alongside each new case insrc/sanitize.test.ts:85-111. Every input is consumed by exactly one recogniser (DCS L51, charset L55, keypad L57, generic two-byte L59, C0/C1 sweep L62), and the expected strings assume the default' 'replacement from L44. - Built and ran
node --test dist/sanitize.test.js: 20/20 pass. - Deleted the charset-designation
.replaceatsrc/sanitize.ts:55and re-ran: onlystrips charset-designation sequences wholefails ('a (Bb'leaks the(Bpayload, as the PR describes). So the new block is a real fail-without-it gate, not a tautology.
No shipped code touched; changelog-guard is green and correctly skipped. Nothing for a maintainer to decide here beyond merging.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Contributor
Author
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
hivecommons-hive
Bot
removed
role/trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds a direct
describe('stripTerminalEscapes')block tosrc/sanitize.test.tsthat pins each recogniser in the shared escape stripper with an input only that recogniser consumes whole.Why
The nightly advisory mutation run on
main(562f1c4, run 40821869628,restshard) leavessrc/sanitize.tsat 81.82% with 8 surviving mutants — 7 of themRegexmutants on the DCS (L51), charset-designation (L55), keypad-mode (L57), generic two-byte ESC (L59) and C0/C1 sweep (L62) patterns, plus the default-replacement literal (L44).The existing
sanitizeForTerminaltests assert that the ESC byte is gone and that surrounding words survive. Because the final control-char sweep removes a stray ESC regardless, a broken recogniser still passes those assertions while the sequence's payload or final byte leaks into the output (\x1b(B→B,\x1bPq…\x1b\\→q…).sanitizeForTerminalalso collapses runs of spaces, which hides whether the C0/C1 sweep is a+run or per-byte, so the new cases callstripTerminalEscapesdirectly and assert exact strings.Re-running Stryker on
src/sanitize.tsalone with this branch: 100.00% (41 killed, 3 timeout, 0 survived).No shipped code changes; test-only, so no
CHANGELOG.mdentry.Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88