Repository navigation
Conversation
Refactor API call to include timeout handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR replaces the native
aiohttptimeout inhas_v2_apiwith Python's strictasyncio.timeout().Currently, when a device drops off the network or crashes, the mDNS/Zeroconf discovery triggers
has_v2_apiin the background. Because it instantiates an unmanagedClientSessionusingaiohttp's internal timeout parameter, DNS resolution or socket creation can occasionally fail to yield, blocking the mainasyncioevent-loop of the consuming application (like Home Assistant) for several seconds.By wrapping the call in
asyncio.timeout(5.0), we guarantee immediate task cancellation if the network hangs, keeping the core event-loop strictly non-blocking.Note: The main
_requestmethods in V1 and V2 already useasyncio.timeoutcorrectly. This patch bringshas_v2_apiin line with the rest of the library.Type of change