Avoid repeated navigation attempts after UI stagnation - #169
Open
getFaster wants to merge 1 commit into
Open
Conversation
getFaster
marked this pull request as ready for review
July 28, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--nav-stagnation-limitand propagate it through worker, master, and input-manager configurationMotivation: Wikipedia navigation livelock
During Wikipedia exploration, the greedy policy could repeatedly select the
same first navigation step when the current state, target, event, and remaining
route length were all unchanged. The target still appeared reachable in the
UTG, so the policy kept retrying it instead of moving to another candidate.
A shortened excerpt from the saved Wikipedia run shows the unchanged state
immediately after a touch:
The saved smoke log contains the no-progress symptom rather than the entire
later livelock. The regression test reproduces the repeated navigation
signature directly. After the configured limit, the policy emits:
It then selects the next reachable target during the same policy cycle.
Testing
python -m unittest discover -s tests -v— 7 tests passedpython -m compileall -q droidbotgit diff --check origin/master..HEAD