feat!: ship distributed 1.0 application, contracts, and render path - #186
Closed
patrickleet wants to merge 1 commit into
Closed
feat!: ship distributed 1.0 application, contracts, and render path#186patrickleet wants to merge 1 commit into
patrickleet wants to merge 1 commit into
Conversation
Remove the copied CLI protocol fingerprint, add deployment validate/render for kubernetes/knative/hops-xr from one manifest+plan pair, and compile e2e-ui clients without constructing a Service. Implements remaining [[tasks/contract-lifecycle-tooling-1]] apply work.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (24)
📝 WalkthroughWalkthroughThe change adds deployment resolution and rendering for three targets, exposes deployment CLI commands, derives protocol identity from library constants, and introduces portable GraphQL module contracts for the e2e UI service. ChangesDeployment pipeline
Portable UI module contracts
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant DistributedCLI
participant resolve_deployment
participant render_resolved
participant OutputDirectory
DistributedCLI->>resolve_deployment: Load and validate manifest and plan JSON
resolve_deployment-->>DistributedCLI: Return ResolvedDeployment
DistributedCLI->>render_resolved: Select target and render resolved deployment
render_resolved-->>DistributedCLI: Return RenderedFile values
DistributedCLI->>OutputDirectory: Create directories and write rendered files
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
Folded into #187 — one PR, not a stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking 1.0 slice of [[tasks/contract-lifecycle-tooling-1]]: compile a typed application to a deterministic
ApplicationManifest+DeploymentPlan, replace productdctlwithdistributed, and render one unchanged pair to kubernetes / knative / hops-xr.1.0.0.[[bin]]name isdistributed.distributed contracts checkstays read-only / fail-closed.distributed deployment validate|renderconsumes one manifest+plan pair.from_contract) and does not construct a repository/Service.distributed.Test output
Linked
Implements [[tasks/contract-lifecycle-tooling-1]] apply work (compiler / CLI / contract-only compile / render).
Follow-up PR: host realize + parseable inventories +
CommandDispatcherGraphQL path.Non-goals
Live cluster apply (task 18), remote Hops repo (task 19),
distributed dev/ hot code push.Summary by CodeRabbit
distributednaming.