Skip to content

Fix Repairer shutdown races and add cloud delivery pipeline - #1035

Merged
hrygo merged 3 commits into
mainfrom
codex/delivery-1033-cloud-pipeline
Oct 9, 2026
Merged

hrygo merged 3 commits into
mainfrom
codex/delivery-1033-cloud-pipeline

Conversation

@hrygo

@hrygo hrygo commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

Fixes #1034
Refs #1033

Repairer shutdown could process the same intent concurrently with its background loop. Shutdown now transfers ownership only after that loop exits, uses one shutdown budget, and leaves in-flight work intact when the budget expires. A single shutdown worker runs callbacks outside the Once lock, so callback re-entry and callers with cancelled contexts cannot deadlock shutdown. Start registration and shutdown are serialized so a late Start cannot create another processing loop.

Adds an explicit Issue-to-draft-PR cloud runner with sequential gates, stale-validation detection, required Git hooks and recoverable commit/push checkpoints. Review fixes also allow an already committed change to resume after revalidation and reuse a previously closed PR instead of creating a duplicate.

Integrated current main after PR #1036 merged, resolving the overlapping Repairer shutdown changes. Both PRs' regression tests are retained; lifecycle changes from main remain intact.

Validation on October 9, 2026:

  • Both shutdown regression groups pass 10 consecutive rounds with race detection and shuffled order, covering blocked processing, concurrent drain callers, interrupted waits, callback re-entry and Start after Shutdown.
  • All 93 Python CI-helper tests pass, including 14 delivery tests.
  • Full make quality passes with zero lint issues and the complete race/shuffle test suite.
  • WebChat and documentation builds pass; make docs-lint passes.
  • Original commit/push hooks run without bypass. GitHub CI validates the updated PR HEAD before merge.

Automatic Codex editing still requires refreshing cloud authentication: the previous implementation probe returned HTTP 401. Validation and PR publication are independently verified. No merge/deployment capability is added to the delivery runner.

@hrygo
hrygo marked this pull request as ready for review October 5, 2026 11:58
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-05T12:15:17.680987Z 2a22962 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hrygo hrygo left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration review for HEAD 839f6bf3ca829227338347efd5a68fefcf517816 on October 9, 2026.

Reviewed all six files in the PR diff against current main. No blocking P0/P1 or worthwhile new P2 findings were identified. The conflict resolution retains a single shutdown processor, transfers intent ownership only after the loop exits, uses one shutdown budget, and runs callbacks outside the Once lock. Both the lifecycle PR's shutdown regressions and this PR's callback/late-Start regressions remain present.

Verified locally:

  • Both shutdown regression groups passed 10 consecutive -race -shuffle=on rounds.
  • All 93 Python CI-helper tests passed.
  • Full make quality passed with zero lint issues and full race/shuffle tests.
  • WebChat and documentation builds, documentation lint, and all six original pre-push gates passed.

GitHub CI for this HEAD is still running. The user explicitly authorized administrator merge only after every check succeeds; no merge has been performed yet.

@hrygo
hrygo merged commit 4119b28 into main Oct 9, 2026
19 checks passed
@hrygo
hrygo deleted the codex/delivery-1033-cloud-pipeline branch October 9, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repairer shutdown races with background processing under race tests

2 participants