Skip to content

fix(deps): remove unused @jsfeb26/urllib-sync (Dependabot #129) - #322

Merged
htilly merged 1 commit into
masterfrom
fix/urllib-credential-leak-dependabot-129
Aug 28, 2026
Merged

fix(deps): remove unused @jsfeb26/urllib-sync (Dependabot #129)#322
htilly merged 1 commit into
masterfrom
fix/urllib-credential-leak-dependabot-129

Conversation

@htilly

@htilly htilly commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes Dependabot alert #129GHSA-hq3h-g68c-hp78 / CVE-2026-55553 (high, CVSS 7.5).

urllib <= 2.44.0 preserves credential-bearing headers (Authorization, Cookie, Proxy-Authorization, etc.) verbatim when following a cross-origin redirect, which can leak credentials to an untrusted origin.

Root cause

@jsfeb26/urllib-sync (pinned to ~2.11.0, added in 2021) was the only dependency pulling in the vulnerable urllib@2.11.1. A repo-wide search found no references to it anywhere in the codebase — it's dead weight.

Fix

Removed @jsfeb26/urllib-sync from package.json and regenerated package-lock.json. This drops the vulnerable transitive urllib entirely, rather than forcing a version override against its tight semver pin.

Verification

  • npm install — no urllib package remains in the lockfile
  • npm test — all 745 tests pass
  • npm audit — remaining findings (ip/SSRF via sonos) are pre-existing and unrelated to this alert

🤖 Generated with Claude Code

Fixes GHSA-hq3h-g68c-hp78 / CVE-2026-55553 (Dependabot alert #129):
transitive urllib <=2.44.0 preserves credential-bearing headers
(Authorization, Cookie, etc.) across cross-origin redirects.

@jsfeb26/urllib-sync was the sole package pulling in the vulnerable
urllib@2.11.1, and it is not referenced anywhere in the codebase
(added in 2021 as a fork of urllib-sync, never used since). Removing
it as dead weight eliminates the vulnerable transitive dependency
entirely rather than forcing an override against its ~2.11.0 pin.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@htilly
htilly merged commit c667b1c into master Aug 28, 2026
5 checks passed
htilly pushed a commit that referenced this pull request Aug 28, 2026
Security: fixed GHSA-hq3h-g68c-hp78 / CVE-2026-55553 (credential
leak on cross-origin redirect) by removing the unused
@jsfeb26/urllib-sync dependency (#322).

Dependency upgrade: posthog-node 5.49.1 -> 5.51.2, including an
upstream fix for a Node 24.16+ memory leak (#321).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant