Skip to content

[any_view] clarify semantics, fix signatures and formatting - #22

Merged
huixie90 merged 1 commit into
huixie90:mainfrom
patrickroberts:main
Sep 28, 2026
Merged

huixie90 merged 1 commit into
huixie90:mainfrom
patrickroberts:main

Conversation

@patrickroberts

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread any_view.md

- [2.8]{.pnum} `reference_converts_from_temporary_v<RValueRef, range_rvalue_reference_t<Rng>>` is `false`, and

- [2.9]{.pnum} `is_convertible_v<range_value_t<Rng>, remove_cv_t<Element>>` is `true`, and

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rendered diff here is confusing because I've actually removed this line and shifted the paragraph numbers accordingly.

Comment thread any_view.md
friend constexpr bool operator>(const @*iterator*@& x, const @*iterator*@& y);
friend constexpr bool operator<=(const @*iterator*@& x, const @*iterator*@& y);
friend constexpr bool operator>=(const @*iterator*@& x, const @*iterator*@& y);
friend constexpr partial_ordering operator<=>(const @*iterator*@& x, const @*iterator*@& y);

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would help simplify the wording, please let me know if this should be reverted.

Comment thread any_view.md

```cpp
auto tmp = *this;
--(*this);

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this was a copy-paste error.

@huixie90
huixie90 merged commit 561fe32 into huixie90:main Sep 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants