Skip to content

fix(search): one title rule for indexing, prefix and exact search (ENG-3299) - #337

Open
adityamishra-hydradb wants to merge 3 commits into
mainfrom
vorflux/adityamishra/eng-3299-title-search-contract-dco
Open

adityamishra-hydradb wants to merge 3 commits into
mainfrom
vorflux/adityamishra/eng-3299-title-search-contract-dco

Conversation

@adityamishra-hydradb

@adityamishra-hydradb adityamishra-hydradb commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

For humans

Documents the normalized title contract from https://linear.app/hydradb/issue/ENG-3299.

What changed

  • Defines NFKC normalization, invisible-formatting and decoration removal, lowercase conversion, whitespace collapse, and consecutive known final extension removal.
  • Documents normalized prefix behavior for list-documents.
  • Documents normalized exact behavior for query and MCP title filters.
  • States that source IDs and titles are separate inputs and are never inferred from input shape.

Merge order

Merge after the app change reaches prod.

Related PRs

For agents

Check that all three surfaces describe the same extension allow-list and the same source-ID-versus-title rule.

Local validation:

npm run hygiene:strict: PASS
npm run verify:agents-endpoints: PASS

Decisions taken without review

  • I documented only behavior implemented by the paired application and ingestion changes.
  • I kept notes.v2 and .md as explicit non-stripping examples to define dotted-title edge cases.
  • I updated the OpenAPI description sources in the application PR. I did not hand-edit generated api-reference/v2/openapi.json.
  • I did not document or implement dashboard shape-based inference because ENG-3304 owns that behavior.
  • I ran validation only on this Vorflux machine. I made no staging or production data call.

Session Details


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Devin Review

@mintlify

mintlify Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
cortex-ai 🟢 Ready View Preview Oct 29, 2026, 3:45 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@github-actions

Copy link
Copy Markdown

✅ Mintlify Hygiene

No issues found.

@openhack-agent

openhack-agent Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

✅ OpenHack Summary

Security review of fix(search): one title rule for indexing, prefix and exact search (ENG-3299). 3 changed files; 0 findings at or above the low reporting threshold.

P1: Critical 0   P2: High 0   P3: Medium 0   P4: Low 0

Confidence Score: 5/5

No reportable security findings were detected in this scan.

Security merge-readiness rubric: 1 = critical, 2 = high, 3 = medium, 4 = low, 5 = no reportable findings. This score reflects scan findings, not a guarantee of correctness or complete coverage.

Files Needing Attention: None

Important Files Changed
  • api-reference/v2/endpoint/list-documents.mdx (modified)
  • api-reference/v2/endpoint/query.mdx (modified)
  • plugins/mcp.mdx (modified)

Last reviewed commit: bbb7945 · View review on OpenHack


TIP: Mention @openhack-agent in a PR comment to request a review or ask a question. Use @openhack-agent fix all for every finding, or @openhack-agent fix unresolved threads for open review threads only.

@openhack-agent openhack-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenHack reviewed this commit. See the OpenHack Summary for the confidence score and fix actions.

@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The documentation appears safe to merge after the paired application change reaches production, as required by the PR description.

Summary

Documents one title rule across listing, querying, and MCP.

  • The list guide describes title matching with normalized prefixes.
  • Query and MCP guides describe exact matches after title cleanup.
  • MCP callers can choose source IDs separately from titles.

Reviews (5) · Last reviewed commit: "docs(search): document MCP source scopes..." · Reviewed by Greptile

greptile-apps[bot]

This comment was marked as resolved.

@adityamishra-hydradb

Copy link
Copy Markdown
Contributor Author

@greptileai review

@adityamishra-hydradb

Copy link
Copy Markdown
Contributor Author

/devin review

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Starting Devin Review.

Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

@adityamishra-hydradb

Copy link
Copy Markdown
Contributor Author

@greptileai review

@adityamishra-hydradb

Copy link
Copy Markdown
Contributor Author

/devin review

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Starting Devin Review.

Devin Review

Signed-off-by: adityamishra-hydradb <321510987+adityamishra-hydradb@users.noreply.github.com>
Signed-off-by: adityamishra-hydradb <321510987+adityamishra-hydradb@users.noreply.github.com>
Signed-off-by: adityamishra-hydradb <321510987+adityamishra-hydradb@users.noreply.github.com>
@adityamishra-hydradb
adityamishra-hydradb force-pushed the vorflux/adityamishra/eng-3299-title-search-contract-dco branch from 48df723 to bbb7945 Compare October 29, 2026 03:45
@adityamishra-hydradb

Copy link
Copy Markdown
Contributor Author

@greptileai review

@adityamishra-hydradb

Copy link
Copy Markdown
Contributor Author

/devin review

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Starting Devin Review.

Devin Review

This branch was successfully deployed

1 active deployment
staging — bbb79452 Deployed Oct 29, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant