Skip to content

docs(collections): explain connector cleanup on deletion - #339

Closed
adityamishra-hydradb wants to merge 1 commit into
mainfrom
vorflux/adityamishra/eng-3301-collection-delete-stops-connectors
Closed

adityamishra-hydradb wants to merge 1 commit into
mainfrom
vorflux/adityamishra/eng-3301-collection-delete-stops-connectors

Conversation

@adityamishra-hydradb

@adityamishra-hydradb adityamishra-hydradb commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

For humans

The delete-collection reference now states that deletion removes dedicated connectors and only matching resources from mixed connectors.

Linear: https://linear.app/hydradb/issue/ENG-3301

Merge this PR only after the application change reaches production.

For agents

  • Base revision: 82850ca5440e56a8a967f147cf6768659ac6ba80 from main.
  • Validation passed:
    • npm run hygiene:strict
    • npm run verify:agents-endpoints
    • npx mintlify validate
  • verify:agents-endpoints checked 54 endpoint mentions.
  • No staging or production service was accessed.
  • Merge order: application first, dashboard second, this docs PR after the application change reaches production.

Decisions taken without review

  • The reference uses one direct behavior sentence because the endpoint semantics changed but the request and response schemas did not.
  • The docs PR stays separate so reviewers can enforce the production-first publishing order.

Session Details


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Devin Review

@mintlify

mintlify Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
cortex-ai 🟢 Ready View Preview Oct 27, 2026, 11:29 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@github-actions

Copy link
Copy Markdown

✅ Mintlify Hygiene

No issues found.

@adityamishra-hydradb

Copy link
Copy Markdown
Contributor Author

@greptileai review

@adityamishra-hydradb

Copy link
Copy Markdown
Contributor Author

/devin review

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Starting Devin Review.

Devin Review

@openhack-agent

Copy link
Copy Markdown

✅ OpenHack Summary

Security review of docs(collections): explain connector cleanup on deletion. 1 changed file; 0 findings at or above the low reporting threshold.

P1: Critical 0   P2: High 0   P3: Medium 0   P4: Low 0

Confidence Score: 5/5

No reportable security findings were detected in this scan.

Security merge-readiness rubric: 1 = critical, 2 = high, 3 = medium, 4 = low, 5 = no reportable findings. This score reflects scan findings, not a guarantee of correctness or complete coverage.

Files Needing Attention: None

Important Files Changed
  • api-reference/v2/endpoint/delete-collection.mdx (modified)

Last reviewed commit: ce9e9a0 · View review on OpenHack


TIP: Mention @openhack-agent in a PR comment to request a review or ask a question. Use @openhack-agent fix all for every finding, or @openhack-agent fix unresolved threads for open review threads only.

@openhack-agent openhack-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenHack reviewed this commit. See the OpenHack Summary for the confidence score and fix actions.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread api-reference/v2/endpoint/delete-collection.mdx
@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The documentation appears safe to merge once the stated production-first rollout condition is met.

Summary

Updates the collection deletion reference:

  • The delete-collection page explains how deletion affects connectors.

No actionable issues found.

Acknowledged intent: adityamishra-hydradb requires the application change to reach production before this documentation merges. The author also explicitly chose a single behavior sentence because the request and response schemas did not change.

Reviews (1) · Last reviewed commit: "docs(collections): explain connector cle..." · Reviewed by Greptile

@adityamishra-hydradb

Copy link
Copy Markdown
Contributor Author

Superseded by #340 because the replacement branch preserves the no-force-push rule and adds the required DCO sign-off.

@adityamishra-hydradb

Copy link
Copy Markdown
Contributor Author

Closing in favor of #340.

This branch was successfully deployed

1 active deployment
staging — ce9e9a0c Deployed Oct 27, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant