Repository navigation
[doc] Remove stale references found by a full doc audit - #216
Merged
cendhu merged 1 commit intoNov 2, 2026
Merged
Conversation
|
coverage: 81.291% (-0.01%) from 81.304% — liran-funaro:doc-stale-meta-namespace-key into hyperledger:main |
liran-funaro
force-pushed
the
doc-stale-meta-namespace-key
branch
2 times, most recently
from
October 21, 2026 09:17
f133161 to
1fd7750
Compare
liran-funaro
force-pushed
the
doc-stale-meta-namespace-key
branch
2 times, most recently
from
October 28, 2026 09:03
4dc255b to
c3599ff
Compare
#### Type of change - Documentation update - Improvement (improvement to code, performance, etc) #### Description - Drop the `MetaNamespacePolicyKey` divergence from `README.md`, `AGENTS.md`, and the `development` and `pr-review` skills. No code ever had that name. The real field, `MetaNamespaceVerificationKey`, was removed in hyperledger#74, so `ARMA` is the only remaining config divergence. - `README.md`: point the provenance list at `tools/configtxgen` (not `internaltools/`) and `cmd/cryptogen` (not the removed `osnadmin`). - `AGENTS.md`: add the missing `common/` packages and `tools/fxadmin`, `pkg/`, `fileutil/` to the structure tree. - `sampleconfig/configtx.yaml` and `docs/configtx.md` §7: list `arma` as an orderer type, mark the endpoint `id` as required, drop the endpoint examples without an `id`, and stop documenting `msp-id`. - `docs/configtx.md`: - §8.5 now documents ACLs as implemented: `configtx.yaml` → the `/Channel/Application` `ACLs` value → `PolicyRefForAPI`, including the committer's gRPC full-method keys merged in hyperledger#209. - §11 now follows the `TwoOrgsSampleFabricX` profile shape (one party per org, on its own host) and lists the `ACLs` value under `Application/Values` as plain YAML. - `LifecycleEndorsement` is labelled as namespace creation and `Endorsement` as transaction endorsement, since Fabric-X has no chaincode. - Add `MaxPartyID` to the `SharedConfig` tree. - `asn1_tx_schema.asn`: rename `protoblocktx.Tx` to `applicationpb.Tx` in the header comment. - `development` skill: `make mocks` also covers interfaces listed in `.mockery.yml`. - Drop the agent symlinks, as hyperledger/fabric-x-committer#873 did in the committer: - Remove the `CLAUDE.md` -> `AGENTS.md` symlink, since Claude Code now reads `AGENTS.md` directly. - Move the skills from `.bob/skills/` to `.claude/skills/`. Before this change `.claude/skills` was a symlink pointing into `.bob/`. - Remove `.bob/rules/01-project-guidelines.md`, which was a symlink to `AGENTS.md`, and with it the rest of the unused `.bob` folder. - Update the `doc-audit` skill, `.gitignore` and `scripts/license-lint.sh` so nothing still points at `CLAUDE.md` or `.bob`. - `.claude/settings.json`: set `attribution` to empty `commit` and `pr` text and `sessionUrl: false`, so Claude Code adds no attribution to commits or PRs made in this repo. #### Related issues - follows up on hyperledger#74 - related to hyperledger#209 Signed-off-by: Liran Funaro <liran.funaro@gmail.com>
liran-funaro
force-pushed
the
doc-stale-meta-namespace-key
branch
from
October 29, 2026 14:46
c3599ff to
4158ad0
Compare
cendhu
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
MetaNamespacePolicyKeydivergence fromREADME.md,AGENTS.md, and thedevelopmentandpr-reviewskills. No code ever had that name. The real field,MetaNamespaceVerificationKey, was removed in remove MetaNamespaceVerificationKey #74, soARMAis the only remaining config divergence.README.md: point the provenance list attools/configtxgen(notinternaltools/) andcmd/cryptogen(not the removedosnadmin).AGENTS.md: add the missingcommon/packages andtools/fxadmin,pkg/,fileutil/to the structure tree.sampleconfig/configtx.yamlanddocs/configtx.md§7: listarmaas an orderer type, mark the endpointidas required, drop the endpoint examples without anid, and stop documentingmsp-id.docs/configtx.md:configtx.yaml→ the/Channel/ApplicationACLsvalue →PolicyRefForAPI, including the committer's gRPC full-method keys merged in [sampleconfig] Add ACLs for the committer's exposed resources to configtx.yaml #209.TwoOrgsSampleFabricXprofile shape (one party per org, on its own host) and lists theACLsvalue underApplication/Valuesas plain YAML.LifecycleEndorsementis labelled as namespace creation andEndorsementas transaction endorsement, since Fabric-X has no chaincode.MaxPartyIDto theSharedConfigtree.asn1_tx_schema.asn: renameprotoblocktx.Txtoapplicationpb.Txin the header comment.developmentskill:make mocksalso covers interfaces listed in.mockery.yml.CLAUDE.md->AGENTS.mdsymlink, since Claude Code now readsAGENTS.mddirectly..bob/skills/to.claude/skills/. Before this change.claude/skillswas a symlink pointing into.bob/..bob/rules/01-project-guidelines.md, which was a symlink toAGENTS.md, and with it the rest of the unused.bobfolder.doc-auditskill,.gitignoreandscripts/license-lint.shso nothing still points atCLAUDE.mdor.bob..claude/settings.json: setattributionto emptycommitandprtext andsessionUrl: false, so Claude Code adds no attribution to commits or PRs made in this repo.Related issues