Repository navigation
updated to latest fabric-x-common to bring new cryptogen changes for reconfig - #304
Merged
Merged
Conversation
…r reconfig Signed-off-by: pco <pasquale.convertini@ibm.com>
Signed-off-by: pco <pasquale.convertini@ibm.com>
…_admin_users` Signed-off-by: pco <pasquale.convertini@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Updates
github.com/hyperledger/fabric-x-commontov0.2.9-0.20260921173349-0565809ff4c3, which adds support for designating specific users as organization administrators incryptogen(via a newAdminfield per user spec), instead of relying solely on the auto-generatedAdminuser.Bumping
fabric-x-commonalone broke the build: the version range also carries an unrelated upstream change that merged theBlockQueryServiceandNotifiergRPC services into a singleSidecarServiceinapi/committerpb.fabric-x-committer v1.0.4predates that merge, so it no longer compiled against the newfabric-x-common. Bumpedfabric-x-committertov1.0.5, which already targets the merged service, and updated our two call sites (tools/fxconfig/internal/client/notifications.go,integration/test/block_query_client.go) fromcommitterpb.NotifierClient/committerpb.BlockQueryServiceClienttocommitterpb.SidecarServiceClient.Additional details (Optional)
Ran
go build ./...,go vet ./..., andgo teston all non-integration packages — all pass. Integration tests were left to the pipeline.