Skip to content

fix(ci): unbreak workflow YAML and add a complete actions.lock - #41

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking
Aug 27, 2026
Merged

fix(ci): unbreak workflow YAML and add a complete actions.lock#41
hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Remediates GitHub Workflow Dependency Locking (public preview, no changelog entry), which rejects runs at startup_failure — zero jobs, no logs, nothing in REST or GraphQL. Full analysis: hyperpolymath/standards#657.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead → 0 startup_failure, 13 running.

Five steps, in order — each blocks the next

1. Unbreak the workflow YAML. Any permissions: carrying a scalar with an indented mapping under it:

permissions: read-all
  actions: read        # <- mapping under a scalar. Unparseable.

This reaches past the one file: gh actions-lock refuses to run when any workflow in the repo fails to parse, so the repo can never acquire a lockfile and can never self-heal.

2. Repin standards reusables off commits with no actions.lock. The rejection requires the callee to be covered at the pinned SHA — unsatisfiable at a pre-lockfile commit.

3. Generate the lockfile with gh actions-lock.

4. Hand-add the reusable-caller entries the tool omits, as '<path>': [].

⚠️ Measured across 218 repos: P(startup_failure | has lockfile) = 91.7% vs 15.8% without — because every workflow a lockfile omits is rejected. A partial lock is worse than none. Running gh actions-lock and stopping there is how this outage spread.

5. Restore SPDX-License-Identifier to line 1, which the tool displaces with its own banner and which the workflow-security linter greps via head -1.

Verified before this PR was opened

0 unparseable workflows · lockfile covers every workflow, no omissions · SPDX on line 1 in every file. The script refuses to push if any of the three fails.

🤖 Generated with Claude Code

Remediates GitHub Workflow Dependency Locking (public preview), which
rejects runs at startup_failure with zero jobs and no logs. See
hyperpolymath/standards#657.

Five steps, in order, because each blocks the next:

1. Unbroke any workflow whose `permissions:` carried a scalar with an
   indented mapping under it - blind-permissions-insertion damage. This
   matters beyond the one file: gh actions-lock refuses to run when ANY
   workflow in the repo fails to parse, so the repo could never acquire a
   lockfile and could never self-heal.

2. Repinned hyperpolymath/standards reusables off commits that have no
   actions.lock. The rejection requires the CALLEE to be covered at the
   pinned SHA, which is unsatisfiable at a pre-lockfile commit.

3. Generated the lockfile with gh actions-lock.

4. Hand-added the reusable-workflow caller entries the tool omits, as
   '<path>': []. Measured across 218 repos: P(startup_failure | has
   lockfile) = 91.7% vs 15.8% without, because every workflow a lockfile
   OMITS is rejected. A PARTIAL lock is worse than none - running
   gh actions-lock and stopping there is how this outage spread.

5. Restored SPDX-License-Identifier to line 1, which the tool displaces
   with its own banner and which the workflow-security linter greps with
   head -1.

Verified before push: 0 unparseable workflows, lockfile covers every
workflow with no omissions, SPDX on line 1 in every file.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead -> 0
startup_failure, 13 running.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hyperpolymath
hyperpolymath merged commit 13b02f6 into main Aug 27, 2026
14 of 16 checks passed
@hyperpolymath
hyperpolymath deleted the fix/workflow-dependency-locking branch August 27, 2026 05:02
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8dc86f43-524d-4231-915d-0b395d2c7320

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea5928 and 445a3e8.

⛔ Files ignored due to path filters (1)
  • .github/workflows/actions.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • .github/workflows/codeql.yml
  • .github/workflows/governance.yml
  • .github/workflows/owned-ci.yml
  • .github/workflows/push-email-notify.yml
  • .github/workflows/secret-scanner.yml

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Added an optional CI check using dedicated compute for pull requests, with results reported directly to the relevant commit.
    • Added manual triggering for the dedicated-compute CI check.
  • Chores

    • Updated automated security, governance, notification and code-quality workflows.
    • Improved workflow permissions and refreshed action and reusable-workflow versions for more reliable maintenance.

Walkthrough

The pull request updates GitHub Actions workflow management markers, action references, reusable workflow revisions, and secret-scanner permissions. It applies these changes across CodeQL, governance, owned CI, email notification, and secret-scanner workflows.

Changes

Workflow maintenance

Layer / File(s) Summary
Action reference updates
.github/workflows/codeql.yml, .github/workflows/owned-ci.yml, .github/workflows/push-email-notify.yml
The workflows add gh actions-lock management comments. CodeQL and email notification actions use updated version references.
Reusable workflow updates
.github/workflows/governance.yml, .github/workflows/secret-scanner.yml
The reusable workflow references use a new commit SHA. The secret-scanner workflow adds actions: read permission.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit checks each workflow line
Tags and SHAs now align
Actions-lock leaves its mark
Permissions guide the scan in dark
CI hops onward, neat and bright


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitar-bot

gitar-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Security 1 high

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The pull request aims to stabilize CI workflows by fixing YAML syntax and implementing dependency locking. However, current Codacy analysis indicates the changes are not up to standards.

A significant gap exists between the stated acceptance criteria and the implementation: while the PR intended to pin actions to specific versions/SHAs to support locking, the 'dawidd6/action-send-mail' action was pinned to a mutable version tag ('v3.12.0') instead of a 40-character commit SHA. This undermines the security goals of the PR.

Additionally, the permissions block in the secret scanning workflow is missing the 'security-events: write' scope, which is typically required for results to properly populate the GitHub Security dashboard. Fixing this is recommended to ensure the CI remains functional for security reporting.

About this PR

  • The specific invalid YAML syntax described (scalar permissions followed by indented mappings) is not explicitly visible in the provided diff hunks, making the 'unbreaking' part of the fix difficult to verify. Additionally, no automated linting was added to the repository to prevent future regressions regarding SPDX header placement or lockfile completeness.

Test suggestions

  • Verify that the SPDX-License-Identifier header is located on the first line of every workflow file.
  • Verify that all GitHub Actions and reusable workflows are pinned to specific versions or SHAs.
  • Verify that every workflow in the repository is covered by an entry in the actions.lock file.
  • Verify that the permissions block in every workflow is syntactically valid and includes 'actions: read' where required.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the SPDX-License-Identifier header is located on the first line of every workflow file.
2. Verify that all GitHub Actions and reusable workflows are pinned to specific versions or SHAs.
3. Verify that every workflow in the repository is covered by an entry in the actions.lock file.
4. Verify that the permissions block in every workflow is syntactically valid and includes 'actions: read' where required.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

steps:
- name: Send push notification email
uses: dawidd6/action-send-mail@0bbdab096651ee93f37ec02383e088183d41ff0b # pinned
uses: dawidd6/action-send-mail@v3.12.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

Pinning third-party actions to a full 40-character commit SHA ensures that the action code cannot be modified without a visible change to the workflow file. Version tags like 'v3.12.0' can be moved by the maintainer to point to different commits.

Try running the following prompt in your IDE agent:

Find the full commit SHA for the tag 'v3.12.0' of the 'dawidd6/action-send-mail' repository and replace the version tag with that SHA, appending the version number as a comment (e.g., uses: dawidd6/action-send-mail@ # v3.12.0).

See Issue in Codacy

group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
permissions:
actions: read

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Suggestion: The workflow defines explicit permissions but omits security-events: write. Most secret scanning tools require this permission to report findings to the GitHub Security dashboard. Consider adding it to ensure results are properly integrated.

Suggested change
actions: read
security-events: write
actions: read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant