fix(rules): unused new in delta/6 breaks --warnings-as-errors on main - #882
Merged
Merged
Conversation
Escript packaging soundness compiles with --warnings-as-errors and has been red on this since #862. Every field delta/6 needs is read from the parsed pins by its callers; nothing downstream reads a ref off a delta. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK
Contributor
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
enabled auto-merge (squash)
September 30, 2026 10:10
hyperpolymath
added a commit
that referenced
this pull request
Sep 30, 2026
Resolves conflicts after #875 squash-merged and #881/#882 landed: cicd_rules hardcoded_tmp takes main's mktemp skip; workflow_hardening keeps with_local_scripts; scanner_suppression test takes main's fixture-based form. mix test: 1713 tests, 0 failures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QFphKkDVB9pUDSCD4bkz65
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfailsmix compile --force --warnings-as-errors(the mode used bytests.yml:109andescript-soundness.yml:141):Why it is on main: #877 was squash-merged at 2026-09-30T10:00Z with commits
09c6b16+e6419d4only. This fix (76b8c89) was pushed to the same branch but did not make the squash, somain(d369a80) carries the warning.Change:
new→_new. One token; no behaviour change.Verified: forced strict compile on this head → rc=0; on
origin/main→ rc=1.🤖 Generated with Claude Code
https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK