fix(rules): JS lockfile advice follows Bun-first runtime policy - #890
Merged
Merged
Conversation
root_hygiene still said "use Deno" for every banned lockfile and marked bun.lockb (and pnpm-lock.yaml) high/delete, the inverse of standards docs/JS-RUNTIME-POLICY.adoc: order Bun > pnpm > npm, Deno banned 2026-09-22, and bun.lock / bun.lockb "permitted and expected". A dispatch acting on the old rule would delete a tier-1 runtime's lockfile. - bun.lockb is no longer banned; bun.lock/bun.lockb are never flagged. - pnpm-lock.yaml drops to a low-severity flag (tier 2, permitted where an upstream toolchain needs node_modules), never a delete. - package-lock.json, yarn.lock, .npmrc stay banned; their remedy and the nodejs_detected reason now say Bun and cite the policy doc. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QFphKkDVB9pUDSCD4bkz65
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Autopilot could not be updated. Open Coding to check access and billing. |
Contributor
|
❌ Failed to create Coding Agent finishing-touch task. Please try again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/rules/root_hygiene.exstill told repos to "use Deno" and markedbun.lockbandpnpm-lock.yamlhigh / delete. That is the inverse ofstandards/docs/JS-RUNTIME-POLICY.adoc:A dispatch acting on the old rule would delete a tier-1 lockfile.
bun.lock/bun.lockbpnpm-lock.yamlpackage-lock.json,yarn.lock,.npmrcnodejs_detectedreasonnpx_in_workflowalready recommendedbunx/bun run, so it needed no change.Verification:
mix testgives 1702 tests, 0 failures (242:verisim_dataexcluded, as on main), andmix format --check-formattedis clean. There are new tests asserting that Bun lockfiles are never flagged and that pnpm is never a delete.Not changed:
test/fixtures/a2ml/rsr-criteria-v2.a2ml(5.1.6 "use Deno") mirrors the standards criteria SSOT. It should be fixed at the source, in standards.🤖 Generated with Claude Code
https://claude.ai/code/session_01QFphKkDVB9pUDSCD4bkz65