Skip to content

docs: add Signed commits section to CONTRIBUTING - #66

Merged
hyperpolymath merged 2 commits into
mainfrom
docs/signing-policy-d218
Oct 1, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
docs/signing-policy-d218

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

This repo's default branch is covered by the zero-bypass Require-Signed-Commits ruleset, and rebase-merge is off. The section tells contributors what that requires:

  • People and interactive agents sign with an SSH signing key.
  • Apps, bots and workflows write through the API, so GitHub signs their commits.
  • PRs are merged with squash.

If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).

This is a docs-only change. The commit was created through createCommitOnBranch, so GitHub signs it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f

Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 18bd6e38-ad85-48b0-820d-f8cd74876b0b

📥 Commits

Reviewing files that changed from the base of the PR and between c55e5a8 and e78be9f.

📒 Files selected for processing (2)
  • .github/CONTRIBUTING.md
  • CONTRIBUTING.adoc

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: beb63c99-8c67-4695-9c5c-e4c1d1e6f52f

📥 Commits

Reviewing files that changed from the base of the PR and between 2cb0f24 and c55e5a8.

📒 Files selected for processing (2)
  • .github/CONTRIBUTING.md
  • CONTRIBUTING.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (14)
  • GitHub Check: governance / Guix primary / Nix fallback policy
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: rust-ci / Detect Cargo.toml
  • GitHub Check: Build, count, mint, lint
  • GitHub Check: CodeQL Analysis (actions, none)
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (2)
CONTRIBUTING.adoc (1)

7-22: LGTM!

.github/CONTRIBUTING.md (1)

26-41: LGTM!


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Contributor guidance now requires commits reaching the default branch to be signed, and unsigned pushes are refused.
    • People and interactive agents must use a GitHub-registered SSH signing key and verified committer email. Apps, bots and workflows must create commits through the API or the approved signed-push action.
    • Pull requests must use squash merge. Unsigned commits require a new branch with signed cherry-picks, and rebase merge is disabled.

Walkthrough

The contribution guides now describe signed-commit requirements for the default branch, signing methods for people and automation, and merge instructions for pull requests.

Changes

Signed Commit Policy

Layer / File(s) Summary
Document signed-commit requirements
.github/CONTRIBUTING.md, CONTRIBUTING.adoc
Both guides require signed commits on the default branch. They describe signing requirements for people and interactive agents, API or estate action workflows for automation, squash merges, and how to handle unsigned commits. They also state that rebase-merge is disabled.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to c55e5

The guides describe the current signed-commit and merge workflow, and no actionable merge risk remains. The PR is ready to merge subject to normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the documentation change to add a Signed commits section to CONTRIBUTING.
Description check ✅ Passed The description directly explains the signed-commit guidance, policy basis, merge requirements, and documentation-only scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks each signed commit,
Then hops through guidance, line by line.
SSH keys mark the path ahead,
Squash merges keep the branches aligned.
The meadow’s rules are clear and fine.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Autopilot could not be updated. Open Coding to check access and billing.

@hyperpolymath
hyperpolymath merged commit a253b7f into main Oct 1, 2026
27 checks passed
@hyperpolymath
hyperpolymath deleted the docs/signing-policy-d218 branch October 1, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant