Repository navigation
fix(dialog): allow a quote from a duplicated current message - #224
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current message is indexed both as a history entry and as the active request. The leak guard counted these identical fingerprints as two copied messages, so an answer quoting part of one message failed with
TranscriptLeak. A production dialog repeatedly hit this false rejection and ended after a partial answer.Count distinct normalized history fingerprints when checking for a multi-message transcript copy. Whole-message echoes, copies from two different messages, speaker-labelled exchanges, and prompt/context protection retain their checks. No new configuration or schema is needed.
Validation: the duplicate-entry regression failed before the fix; 2465 workspace/all-target tests passed, 10 ignored; formatting, diff checks and workspace/all-target Clippy passed. Provider-level coverage includes a current message also present in history. All four rejected production candidates were replayed locally against their original context: the old guard rejects them, the patched guard accepts them. No live message was replayed or sent.