Repository navigation
Read only the claimed dialog record from taskman - #226
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claiming a dialog cloned every taskman record to retrieve the selected job's causation updates. Production retains almost 19,000 terminal jobs, including dialog checkpoints, so each new turn copied the archive while holding the queue lock. Use the existing single-record lookup instead.
Remove the same unnecessary archive copies when reporting startup restore counts and checking whether the taskman inspector is configured. Keep every persisted record, terminal retention, ordering, claim timestamp, and causation update unchanged.
Validation: 2467 workspace tests passed (10 ignored), formatting and diff checks, all-target Clippy with warnings denied. A regression checks the selected job, source updates, latest update, claim timestamp, and retained terminal history. A local benchmark calls the real dialog dequeue adapter 20 times with 1,000 completed jobs containing 62.5 MiB of payload: peak RSS drops from 138.2 to 71.1 MiB and median claim time from 1,844 to 28 microseconds. These are local debug measurements; production memory and latency still require observation.