Repository navigation
Bound reaction tool choices to supported emoji - #227
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reaction tool accepts a fixed emoji list, but its schema exposed an unrestricted string. Recent dialogs selected unsupported emoji and the runtime rejected them. Publish the existing allowlist as a schema enum so the model can select valid reactions before calling the tool.
Lifecycle reactions remain reserved and runtime validation is unchanged.
Validation: regression failed before the schema change;
cargo test --workspace --all-targetspassed (2468 tests, 10 ignored);cargo fmt --all;cargo clippy --workspace --all-targets -- -D warnings.