Repository navigation
Preserve pending drawing requests across initiator follow-ups - #228
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new initiator message could erase an unexecuted explicit drawing request before the first model call. Production evidence showed “thanks” replacing the request and a text response with no drawing call.
Keep the pending tool and original image order when additional messages arrive. A new image intent or an explicit cancellation can replace it. After a tool attempt, updates retain the existing behavior. Apply the same rule to observed history and injected messages.
Validation: the production-shaped regression failed before the fix; workspace tests cover both message paths and cancellation;
cargo fmt --all;cargo test --workspace --all-targets(2470 passed, 10 ignored);cargo clippy --workspace --all-targets -- -D warnings.