Repository navigation
Decode Central Bank rates with the declared XML encoding - #229
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The currency tool rejected the Central Bank XML response as invalid UTF-8. The live endpoint declares Windows-1251 in both its HTTP header and XML declaration.
Deserialize the original bytes through the existing XML parser with its encoding feature enabled. This preserves source dates, values, caching and validation. No new crate version is added. The HTTP fixture now supports binary response bodies.
Validation: a Windows-1251 HTTP regression failed with the original decoder, then passed; existing UTF-8 XML and currency cross-pair tests passed;
cargo fmt --all;cargo test --workspace --all-targets(2471 passed, 10 ignored);cargo clippy --workspace --all-targets -- -D warnings.