Floor applied to the dataset prior BaseAngularErrorModifier

[sathanas31]

The load_data() of IceCubeSeason is always called with floor = True, which means that a floor = 0.2deg is always applied. This is ok for the default behaviour where static_floor is applied, but if no_floor is chosen, or if you want to change the min_angular_err then it gets incosistent. In the latter case, the min_angular_err is currently not configurable. If that is desirable, then it could be added in the llh (or mh) dict as another key, which is passed when creating the BaseAngularErrorModifier in add_angular_error_modifier, eg

BaseAngularErrorModifier.create(
season,
self.llh_dict["llh_energy_pdf"],
self.floor_name,
self.pull_name,
gamma_precision=self.llh_dict.get("gamma_precision", "flarestack"),
sigma_floor=self.llh_dict.get("min_error_deg", min_angular_err),
)

Also, @jvansanten found that a floor = 0.1deg has already been applied in the NT (v5p01) MC to begin with, so even for no_floor the angular error is still > 0.1deg. This cannot be configured, as it's directly from the npy file. It probably exists in the other NT datasets, maybe also in PSTracks too, but I haven't checked, it's more of an FYI

[mlincett]

If there is a practical need for it, then it should be configurable.

Also, @jvansanten found that a floor = 0.1deg has already been applied in the NT (v5p01) MC to begin with, so even for no_floor the angular error is still > 0.1deg. This cannot be configured, as it's directly from the npy file. It probably exists in the other NT datasets, maybe also in PSTracks too, but I haven't checked, it's more of an FYI

I guess flarestack could be smart enough to check the angular error floor against the minimum angular error observed in the data and MC, so the user can be made aware of what is going on in that regard.