Skip to content

chore(release): S1API 3.2.3 - #390

Merged
ifBars merged 2 commits into
stablefrom
releases/3.2.3
Nov 3, 2026
Merged

ifBars merged 2 commits into
stablefrom
releases/3.2.3

Conversation

@ifBars

@ifBars ifBars commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Prepares 3.2.3 with the unreleased NPC fixes and loading improvements from #381, #384, #385 and #388. Updates both version fields, adds curated release notes, and removes the broken DeepWiki README badge.

Release maintenance requested by the maintainer; follows VERSIONING.md. The badge cleanup is documentation-only.

Validation

Fresh serial builds and full suites passed: MonoMelon 862/862 and Il2CppMelon 825/825, zero failed or skipped. Release loader builds. Linked PR reviews include live Mono/IL2CPP seat, loading, co-op and mugshot checks. The version/docs-only preparation reuses that runtime evidence.

Compatibility

No public API, save identifier or network format changes in this preparation. Both runtime packages and the loader layout are retained. The pre-existing join-before-load unlock issue remains tracked in #386.

After hosted checks: merge to stable, fast-forward releases/3.2.3 to the merge commit, then tag v3.2.3 to publish.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

This pull request adds release notes for version 3.2.3 and updates the Melon metadata and package versions from 3.2.2 to 3.2.3.

Changes: 3.2.3 release

Layer / File(s) Summary
Release notes and version updates
.github/release-notes/3.2.3.md, S1API/S1API.cs, S1API/S1API.csproj
The release notes describe NPC fixes, loading changes, compatibility and validation details, and release links. The Melon metadata and package versions change to 3.2.3.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

  • ifBars/S1API#388: The 3.2.3 release notes describe the mugshot disk cache and its behavior.
  • ifBars/S1API#384: The release notes document the co-op NPC behavior-stack and schedule fix.
  • ifBars/S1API#381: The release notes document the sit-action seat-set initialization fix.
Merge Risk: Minimal · up to a4d95

The release preparation is ready to merge based on the supplied evidence.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description states the purpose: preparing the 3.2.3 release with NPC fixes and loading improvements from #381, #384, #385 and #388, updating both version fields, adding release notes, and removing… Add a Linked issue section. Link the issue for the release preparation or explain the documentation-only exception with maintainer approval, and state that the author checked for duplicate work. Complete the contributor checklist. Fill in S…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies this as the S1API 3.2.3 release preparation and matches the changes.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

Full details: Description check

Explanation

The description states the purpose: preparing the 3.2.3 release with NPC fixes and loading improvements from #381, #384, #385 and #388, updating both version fields, adding release notes, and removing a broken README badge. It gives validation results for Mono (862/862) and IL2CPP (825/825), and compatibility statements about public API, saves, and network formats. It does not follow the template's required sections. The Linked issue section is missing: it neither links an issue with Fixes/Refs nor explains an exception, and it does not say whether the badge-removal docs-only change qualifies as an allowed exception. The contributor checklist is absent. The Summary section does not describe the modder-facing outcome or the native/runtime seam. The Compatibility section does not use the template's inventory of changed public/protected symbols, although it does state that none changed. The Validation section does not use the Mono and IL2CPP subsections, and the Runtime evidence section is not filled in. The description relies on linked PR reviews for runtime evidence, which the template says must be kept local. The Documentation section does not list the README badge change or the release notes file.

Resolution

Add a Linked issue section. Link the issue for the release preparation or explain the documentation-only exception with maintainer approval, and state that the author checked for duplicate work. Complete the contributor checklist. Fill in Summary with the modder-facing outcome of the 3.2.3 fixes and loading changes. Complete Compatibility by listing changed public/protected symbols and durable IDs, and state explicitly that none changed for the version bump. Split Validation into Mono and IL2CPP subsections with the build, test, and in-game scenarios run. Fill in Runtime evidence or state why it does not apply to this version-only change. List the release notes file and the README badge removal under Documentation.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2e3b9fe8-9832-4fba-a161-d85874358c5c
Commits

Reviewing files that changed from the base of the PR and between 671dde1 and a4d95c3.

Files selected for processing: 3
  • .github/release-notes/3.2.3.md
  • S1API/S1API.cs
  • S1API/S1API.csproj

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@ifBars
ifBars merged commit c81076d into stable Nov 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant