In /leaderboards/song and /leaderboards/battle, add support for User Band Name Fallback - #21
Open
elcanadiano wants to merge 1 commit into
Open
Conversation
This adds support for User Band name fallback when a band name does not exist. For example, if a user steven3333 does not have a band name, in the game, we will likely see steven3333's band as the band name. However, in the Leaderboards, it just falls back to Unnamed Band. We shouldn't do that here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I've been working on GoCentralScores.com, which aims to build a Keldon, RockBandStats.com, or a RB4Scores.com but for the GoCentral server. I think I've largely built on what we can reasonably do with what the existing API can do. I would love to propose some additional architectural changes in the future but for now I just want to propose some quick wins.
I was noticing that a lot of the band entries contain "Unnamed Band" in the API and was wondering why and noticed the reason for it. Hence, I'd like to propose a fix/improvement. This is sort of a primitive/quick fix and it seems like we can definitely make some significant improvements to both this approach and to this PR.
We have a significant refactoring opportunity where we could likely refactor all of the fallback names instances to a
utilsfunction. I will not do that here by default unless we think we should.Proposed changes
resolveBandDisplayNamewithinrestapi.goGetUsernamesByPIDsinBattleLeaderboardHandlerandLeaderboardHandlerUsername's Bandfirst if the band is not supported.mongo-dataentry on.gitignoreScreenshots
This example would be the Band Leaderboard. Consider in this example, the 9th place entry has "Unnamed Band" in the API/GoCentralScores but is listed as "Lewis21388's Band" in the game.
GoCentralScores
Rock Band 3