Repository navigation
Commit package-lock.json and build with npm ci - #27
Merged
Merged
Conversation
package-lock.json was gitignored, so every CI run installed the newest dependencies. webpack 5.112.0 (2026-10-15) moved lib/Cache.js to lib/cache/Cache.js, and html-bundler-webpack-plugin (via pug-plugin, latest 4.23.2) still requires 'webpack/lib/Cache', so every build has failed since: "Cannot find module 'webpack/lib/Cache'". Pinning webpack alone is not enough, minimizer-webpack-plugin 5.13 breaks the CSS minify step of webpack 5.111. The committed lockfile is the one the last green build (2026-09-27) was made with (webpack 5.111.1). With npm ci a clean checkout builds again and produces a dist/index.js identical to the committed one. Dependencies now only change when the lockfile is updated on purpose. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ihsoyCT
pushed a commit
that referenced
this pull request
Oct 30, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI has been failing on every fresh install since webpack 5.112.0 (2026-10-15): it moved
lib/Cache.jstolib/cache/Cache.js, andhtml-bundler-webpack-plugin(pulled in bypug-plugin, latest release still affected) requireswebpack/lib/Cache. Becausepackage-lock.jsonwas gitignored, CI always installed the newest versions. Pinning webpack alone is not enough:minimizer-webpack-plugin5.13 then breaks the CSS minify step.This commits the lockfile the last green build used (webpack 5.111.1) and switches both workflows (PR build and the GitHub Pages deploy) to
npm ci. Verified in a clean checkout:npm ci && npm run build:prodsucceeds anddist/index.jsis byte-identical to the committed one.Needs to be merged before #26, otherwise its build (and the Pages deploy on master) fails.
🤖 Generated with Claude Code