Repository navigation
Scope version-bump check to pull requests only - #3
Merged
Merged
Conversation
The version-bump job in verify.yml also ran on push to main, so it fired again after every merge and always failed since main's Cargo.toml version equals the tag release.yml just created for it. It was only ever meant to gate PRs (see the comment in release.yml).
imohsenb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version-bumpjob inverify.ymlran onpush: branches: [main]as well aspull_request, so it re-ran after every merge tomainand always failed there:release.ymltags the just-mergedCargo.tomlversion immediately, so by the time (or shortly after)verify.ymlre-checks on themainpush, the current version equals the latest tag and the job errors out (version (1.0.0) must be bumped above the latest release tag (1.0.0)), see run https://github.com/imohsenb/git-task/actions/runs/31130055172.release.yml), so addif: github.event_name == 'pull_request'to restrict it to that trigger.Cargo.toml/Cargo.lockto1.0.1so this PR itself passes the (now PR-only) version-bump gate.Test plan
cargo buildcargo test --workspace --locked