Repository navigation
Publish release as draft until binaries are attached - #5
Merged
Merged
Conversation
softprops/action-gh-release published the release immediately, but GitHub's immutable-release rule blocks asset uploads to a published release -- the build-binaries job's uploads all failed against v1.0.2. Create the release as a draft, upload binaries to it across the matrix, then publish once everything's attached.
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-binariescould attach assets; GitHub's immutable-release rule then rejected every upload (Cannot upload asset ... to an immutable release), so v1.0.2 shipped with zero binaries.tag-release, upload all 4 platform tarballs to it inbuild-binaries, then flip it to published in a newpublish-releasejob once uploads finish.tag-releaseskips already-tagged versions).Test plan
cargo checkwith bumped version.