feat: add Query and MustQuery for the HTTP QUERY method (RFC 10008)#508
Open
thatwasyahya wants to merge 1 commit into
Open
feat: add Query and MustQuery for the HTTP QUERY method (RFC 10008)#508thatwasyahya wants to merge 1 commit into
thatwasyahya wants to merge 1 commit into
Conversation
RFC 10008 defines QUERY, a safe and idempotent method that carries the query as request content. Query mirrors Get/Post and MustQuery mirrors MustGet. req already sends a body for non-GET/HEAD/OPTIONS methods, so SetBody(...).Query(url) works as-is. Extends TestSendMethods with a QUERY case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
QueryandMustQueryverb helpers for the HTTP QUERY method.Why
RFC 10008 (Proposed Standard, June 2026) defines QUERY, a safe and idempotent method that carries the query as request content — like
GETbut with a body, and unlikePOSTit is safe, idempotent and retryable. It's a good fit for large or structured queries that don't belong in a URL.What's added
Request.Query(url)— mirrorsGet/Post, sending theQUERYmethod.Request.MustQuery(url)— mirrorsMustGet.No other changes are needed: req already sends the request body for methods other than GET/HEAD/OPTIONS, so
client.R().SetBody(...).Query(url)works out of the box.Tests
Extends
TestSendMethodswith aQUERYcase.go test ./...passes.