Add structured server event recorder - #314
Closed
pcarrier wants to merge 4 commits into
Closed
Conversation
|
Found 16 test failures on Blacksmith runners: Failures
...and 6 more test failures. View all on Blacksmith
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.png)
Coverage
|
![indent[bot]](https://avatars.githubusercontent.com/in/4161513?s=60&v=4){kind=small}
| } | ||
|
|
||
| fn selector_ids(selector: &str) -> Option<Vec<u8>> { | ||
| if let Ok(id) = selector.parse::<u8>() { |
There was a problem hiding this comment.
This accepts any u8 (0–255), but the event-id space is only 0–127 (the activation mask is 128 bits / 16 bytes). For ids 128–255, parse_activation then calls activation.set(id, enabled), and Activation::set (crates/remote/src/events.rs:70) indexes self.0[id as usize / 8] on a [u8; 16] — index >= 16 — which panics at runtime. So blit events config set --active 200 (or e.g. --active pty,200) aborts the CLI with a panic instead of the graceful blit: ... error. Bound this branch to id < 128 so out-of-range ids fall through to the existing "unknown event selector" error. Existing tests only use ids <= 127, so this is uncaught.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blit.events.v1binary protocol and fixed-size server event ringblit eventsconfig, dump, stream, and file commands plus startup env configurationThe default is a 1 MiB ring with only low-rate lifecycle and error events active. High-throughput request, writer, PTY I/O, process I/O, frame, and protocol families are opt-in through the 128-bit activation mask.
Verification
cargo test -p blit-remote -p blit-cli(494 tests)cargo test -p blit-server events(21 tests)cargo clippy -p blit-remote -p blit-server -p blit-cli -- -D warningsThe full
blit-serversuite was attempted but exceeded the 10-minute sandbox command limit; no matching test processes survived. The scoped server suite and strict compilation/clippy checks pass.Tag
@indentto continue the conversation here.