Conversation
The section claims a panic for any duplicated key, but get_disjoint_opt_mut only reaches the duplicate check inside `if let Some(idx)`, so duplicated keys that are absent from the map yield None instead of panicking. The behaviour matches std::collections::HashMap::get_disjoint_mut and is not changed here; only the doc sentence is corrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndexMap::get_disjoint_mutdocuments an unconditional panic:It does not panic on duplicated keys that are absent from the map — only on duplicates that actually resolve to the same index. Narrowed the claim to what the body does.