Remove message bubbles and poll shortcodes - #7
Merged
injoon5 merged 3 commits intoAug 16, 2026
Conversation
Drop :::messages/:::chat and :::poll from the markdown renderer, their CSS, and the tests that covered them. Unknown leftover blocks render as ordinary prose. Co-authored-by: Injoon Oh <injoon5@icloud.com>
injoon5
marked this pull request as ready for review
August 16, 2026 16:16
node:sqlite on Node 22 treats ?N placeholders as named parameters, so
spreading bind args throws. Bind them as {"?1": v, ...} in the suite;
D1 still gets the same SQL positionally.
Co-authored-by: Injoon Oh <injoon5@icloud.com>
svelte-check rejected Record<string, unknown> against StatementSync.run. Co-authored-by: Injoon Oh <injoon5@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kill
:::messages/:::chat(iMessage bubbles) and:::poll(result bars) completely.Also unblocks the visitor-migration suite on Node 22:
node:sqlitetreats?Nas named params, so those three tests now bind{"?1": v}asSQLInputValueinstead of spreading args. D1 SQL is unchanged.npm test(105) andnpm run checkare green.