Skip to content

Fix/439 s freq j optional args and validation #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vikram-rawat wants to merge 4 commits into from
Closed

Fix/439 s freq j optional args and validation #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a589c71
chore: preserve dev/ after upstream sync
vikram-rawat Oct 6, 2026
13a67d4
feat: test junco@fix/439-s-freq-j-optional-args-and-validation
vikram-rawat Oct 6, 2026
59d8cd3
remove extra code
vikram-rawat Oct 7, 2026
17155a3
update snapshot
vikram-rawat Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .Rbuildignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,4 @@ images
^.revdeprefs\.yaml$
^revdep$
^\.covrignore$
^dev/
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Suggests:
VignetteBuilder:
knitr
Remotes:
johnsonandjohnson/junco@dev,
johnsonandjohnson/junco@fix/439-s-freq-j-optional-args-and-validation,
johnsonandjohnson/pharmaverseadamjnj@main,
johnsonandjohnson/pharmaversesdtmjnj@main,
pharmaverse/formatters@main,
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/_snaps/tsflab01apart2/tsflab01apart2of3.rtf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,8 @@
\clbrdrt\clbrdrl\clbrdrb\clbrdrr\clvertalb\cellx8899
\clbrdrt\clbrdrl\clbrdrb\clbrdrr\clvertalb\cellx12701 \pard\intbl\ql\fs18 \intbl\li267\fi-87 Cycle 03 \cell
\pard\intbl\qc\fs18 0/5 \cell
\pard\intbl\qc\fs18 NE (NE, NE) \cell
\pard\intbl\qc\fs18 NE (NE, NE) \cell
\pard\intbl\qc\fs18 NA \cell
\pard\intbl\qc\fs18 NA \cell
\row
}

Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/tsflab01apart3/tsflab01apart3of3.rtf
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@
\pard\intbl\qc\fs18 4.38 (3.88, 4.88) \cell
\pard\intbl\qc\fs18 -0.02 (-0.62, 0.59) \cell
\pard\intbl\qc\fs18 -0.20 (-0.81, 0.41) \cell
\pard\intbl\qc\fs18 NE (NE, NE) \cell
\pard\intbl\qc\fs18 NA \cell
\row
}

Expand Down
8 changes: 4 additions & 4 deletions tests/testthat/_snaps/tsids02/tsids02.rtf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,8 @@
\pard\intbl\qc\fs18 43 (51.2%) \cell
\pard\intbl\qc\fs18 22 (25.6%) \cell
\pard\intbl\qc\fs18 114 (44.9%) \cell
\pard\intbl\qc\fs18 0.0 (0.0, 0.0) \cell
\pard\intbl\qc\fs18 0.0 (0.0, 0.0) \cell
\pard\intbl\qc\fs18 32.8 (18.7, 46.8) \cell
\pard\intbl\qc\fs18 25.6 (11.5, 39.7) \cell
\row
}

Expand Down Expand Up @@ -320,8 +320,8 @@
\pard\intbl\qc\fs18 48 (57.1%) \cell
\pard\intbl\qc\fs18 24 (27.9%) \cell
\pard\intbl\qc\fs18 116 (45.7%) \cell
\pard\intbl\qc\fs18 0.0 (0.0, 0.0) \cell
\pard\intbl\qc\fs18 0.0 (0.0, 0.0) \cell
\pard\intbl\qc\fs18 24.5 (10.2, 38.8) \cell
\pard\intbl\qc\fs18 29.2 (15.0, 43.4) \cell
\row
}

Expand Down
Loading