fix(collector): cleaned up request objects after agent host lookup#1908
Draft
kirrg001 wants to merge 2 commits into
Draft
fix(collector): cleaned up request objects after agent host lookup#1908kirrg001 wants to merge 2 commits into
kirrg001 wants to merge 2 commits into
Conversation
kirrg001
force-pushed
the
fix-destr-req-agentlookup
branch
from
August 18, 2025 11:07
9fa18bc to
3c21d78
Compare
kirrg001
changed the title
kirrg001
marked this pull request as ready for review
August 18, 2025 11:39
aryamohanan
requested changes
Aug 29, 2025
aryamohanan
left a comment
aryamohanan
left a comment
Contributor
There was a problem hiding this comment.
The tests appear to be failing on tekton because req.destroy() is being called from test, but this method does not exist on the FakeRequest class.
kirrg001
marked this pull request as draft
September 11, 2025 10:08
kirrg001
force-pushed
the
fix-destr-req-agentlookup
branch
from
February 24, 2026 09:20
3ccb76f to
dc028f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while investigating #1886
refs https://jsw.ibm.com/browse/INSTA-35539