[2051 by GPT-5.6 Sol] Make packaged Windows Connect smoke lifecycle bounded and path-redacted - #2054
Merged
integry merged 5 commits intoSep 2, 2026
Conversation
![propr-dev[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…fecycle boun Implemented by ProPR AI using gpt-5.6-sol model. Implementation completed successfully.
Owner
|
Ultrafix follow-up on exact head 678e573. Preserve the current lifecycle design and scope, but correct two independently reproduced blockers:
Keep taskkill absolute-path authority, shell:false, exact PID /T /F arguments, bounded close/drain, exact ready-key validation, canonical generated-leaf authorization, fixed sanitized diagnostics, and primary-error preservation unchanged. Run focused tests and typecheck, and report the exact new head. |
Contributor
Author
|
✅ Applied the requested follow-up changes in commit 0c4ffa6 Summary of ChangesImplemented the two requested follow-up fixes in: Changes include recursive decoded-JSON sensitive-string inspection, real cleanup phase deadlines, and isolated default Windows filesystem cleanup so stuck native requests cannot hold the harness open. Existing taskkill, readiness, sanitization, retry, and primary-result behavior remains intact. Validation:
Per instruction, I did not commit. The exact checked-out head remains 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
Full Test Suite ResultsValidation failed during: Full test suite.
View Test Output |
Implemented the two requested follow-up fixes in: - [packaged-connect-lifecycle.mjs](/tmp/git-processor/worktrees/integry/propr/pr-2054-followup-2026-09-01T22-25-29/apps/desktop/scripts/packaged-connect-lifecycle.mjs:120) - [packaged-connect-lifecycle.test.mjs](/tmp/git-processor/worktrees/integry/propr/pr-2054-followup-2026-09-01T22-25-29/apps/desktop/scripts/packaged-connect-lifecycle.test.mjs:251) Changes include recursive decoded-JSON sensitive-string inspection, real cleanup phase deadlines, and isolated default Windows filesystem cleanup so stuck native requests cannot hold the harness open. Existing taskkill, readiness, sanitization, retry, and primary-result behavior remains intact. Validation: - Lifecycle/cleanup tests: 19/19 passed - Related smoke-support tests: 11/11 passed - ESLint: passed - `git diff --check`: passed - Desktop typecheck: blocked by the pre-existing untouched `src/window-options.test.ts:15` `string`/`Rectangle` error Per instruction, I did not commit. The exact checked-out head remains `678e573b005f9623cbb6380622ca4216e3b3a431`; the automation-generated post-commit head is therefore not yet available. PR: #2054 Comment by: @integry (ID: 5501251882) Model: gpt-5.6-sol
Owner
|
Final narrow lifecycle correction on exact head 0c4ffa6. Preserve the audited killable Windows cleanup child, real authorization/removal deadlines, primary-result preservation, and decoded JSON sensitive-value scanning, but close one remaining bounded-capture bypass. createRecordCapture stops structured JSON parsing after recordCount reaches 128 and after the 64 KiB capture budget. Raw scanning cannot detect JSON-escaped Windows backslashes, and a previously observed ready record can still produce success when capture is marked truncated. Therefore ready + enough benign records/bytes + a later JSON-escaped sensitive path + clean exit can be accepted. Fail closed: any record-count or byte-budget truncation must revoke/preclude ready success with one fixed sanitized category, or equivalently continue a separate bounded streaming sensitive scan that cannot be bypassed by JSON escaping. Do not expose raw content or paths. Add deterministic post-ready tests for both exceeding the record-count cap and exceeding the byte cap followed by a JSON-escaped Windows sensitive path and clean exit; neither may succeed. Retain the existing before/after-ready Windows path tests and never-settling cleanup tests. Run focused tests/typecheck and report the exact new head. Base synchronization with transport head 1c02016 will be requested separately after this correction lands. |
Contributor
Author
|
✅ Applied the requested follow-up changes in commit 657374d Summary of ChangesImplemented the fail-closed capture correction.
Validation:
Per instruction, changes are uncommitted. Exact checked-out head remains 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
Implemented the fail-closed capture correction. - Any truncated capture now converts ready success to fixed sanitized category `output-rejected`: [packaged-connect-lifecycle.mjs](/tmp/git-processor/worktrees/integry/propr/pr-2054-followup-2026-09-01T22-37-25/apps/desktop/scripts/packaged-connect-lifecycle.mjs:457) - Added deterministic post-ready record-count and byte-budget bypass tests: [packaged-connect-lifecycle.test.mjs](/tmp/git-processor/worktrees/integry/propr/pr-2054-followup-2026-09-01T22-37-25/apps/desktop/scripts/packaged-connect-lifecycle.test.mjs:287) Validation: - Focused lifecycle/cleanup suite: 21/21 passed - ESLint: passed - `git diff --check`: passed - Desktop typecheck: blocked by the existing untouched `src/window-options.test.ts:15` `string`/`Rectangle` error Per instruction, changes are uncommitted. Exact checked-out head remains `0c4ffa6dd916b0947bb0e10e2be8bcf7d1301606`; the system-generated commit will establish the new head. PR: #2054 Comment by: @integry (ID: 5501363330) Model: gpt-5.6-sol
Owner
|
/merge |
Contributor
Author
|
🔀 Auto-merged No conflicts were found — the merge was verified by an AI agent. 🤖 Verification Details
System-triggered merge conflict resolution |
… into 2051/gpt-5.6-sol-make-packaged-windows-con-20260901-2205-5rn
Owner
|
/merge |
Contributor
Author
|
🔀 Auto-merged No conflicts were found — the merge was verified by an AI agent. 🤖 Verification Details
System-triggered merge conflict resolution |
… into 2051/gpt-5.6-sol-make-packaged-windows-con-20260901-2205-5rn
integry
merged commit Sep 2, 2026
7bcfcff
into
1953-epic-desktop-transport-api
20 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Implementation Summary
Closes #2051
Branch:
2051/gpt-5.6-sol-make-packaged-windows-con-20260901-2205-5rnCommits: ✅ Changes committed (678e573)
AI Processing Completed
Execution Details:
Summary:
Implemented the bounded, path-redacted packaged Connect lifecycle.
Key changes:
taskkill /PID <pid> /T /Ftermination with stream draining and fallback handling.EBUSYretries, and primary-error preservation.Files:
Validation:
git diff --checkpassed.Detailed Logs:
01a05f02-7023-7080-8e5e-864df8a2f97cLog files stored at:
/tmp/claude-logs/issue-2051-2026-09-01T22-20-33-567Z-conversation.json/tmp/claude-logs/issue-2051-2026-09-01T22-20-33-567Z-output.txtLatest Conversation Messages
This PR was created automatically by ProPR after processing issue #2051.
💡 Need changes?
Comment on this PR to request refinements — the AI agent monitors comments and will update the implementation based on your feedback. Keep iterating until you're satisfied!