[2052 by GPT-5.6 Sol] Make Windows ownership capture authority durable before interruption - #2055
Conversation
…ty durable b Implemented by ProPR AI using gpt-5.6-sol model. Implementation completed successfully.
|
Ultrafix follow-up on exact head 2be43cc. Keep the production authority-publication ordering and all existing F10-F24 semantics, but close the independent deterministic-proof gap. Add a controlled helper-process test matrix covering process death immediately before authority publication, during durable publication, and immediately after committed publication. The DURING case must exercise the real durability sequence: the child writes the .new authority record with FileStream WriteThrough, calls Flush(true), signals the parent only after that flush, and the parent kills the child before the atomic rename/replace. Then invoke the real cleanup/controller path and prove that it resumes only the byte-identical exact next generation. Also prove that partial, foreign, stale, or generation-mismatched .new records are rejected and that the exact authorized tree is cleaned without widening path/deletion/identity authority. Do not substitute WriteAllText or an in-process exception for process death and durable flush evidence. Preserve schema v3 identifiers, NONPROVISIONAL/COMMITTED reread requirements, startup classifications, fixed protocol output, and existing deletion rules. Run the deterministic Windows tests on both x64 and ARM64 where the workflow supports them, plus static tests/typecheck, and report the exact new head. |
|
✅ Applied the requested follow-up changes in commit 66cffbe Summary of ChangesImplemented the deterministic publication-death proof without committing. Key changes:
Validation:
Per instruction, no commit was created. Exact current HEAD remains 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
…ut committing. Implemented the deterministic publication-death proof without committing. Key changes: - Added real cleanup-worker process-death gates for `BEFORE`, `DURING`, and `AFTER` publication in [cleanup-installed-windows-app.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2055-followup-2026-09-01T22-25-38/apps/desktop/scripts/cleanup-installed-windows-app.ps1). - DURING signals only after `FileStream` `WriteThrough`, `Flush(true)`, and close, before atomic replacement. - Added byte-identical recovery and partial/foreign/stale/generation-mismatched `.new` rejection tests in [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2055-followup-2026-09-01T22-25-38/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1). - Added static ordering and matrix guards in [release-workflow.test.ts](/tmp/git-processor/worktrees/integry/propr/pr-2055-followup-2026-09-01T22-25-38/apps/desktop/src/release-workflow.test.ts). - Existing workflow coverage already runs the deterministic suite on native Windows x64 and ARM64. Validation: - Desktop suite: 177 passed, 6 platform-specific skips. - Release workflow tests: 23/23 passed. - Desktop typecheck: passed. - `git diff --check`: passed. - Native Windows execution awaits the configured x64/ARM64 CI runners. Per instruction, no commit was created. Exact current HEAD remains `2be43cc6b717c6c1cc9ae2a4156792efd5069898`; the system-generated new head is not available until it commits these changes. PR: #2055 Comment by: @integry (ID: 5501253656) Model: gpt-5.6-sol
AI Implementation Summary
Closes #2052
Branch:
2052/gpt-5.6-sol-make-windows-ownership-ca-20260901-2205-od8Commits: ✅ Changes committed (2be43cc)
AI Processing Completed
Execution Details:
Summary:
Implemented the Windows ownership publication fix.
Key changes:
Generationand explicitAuthorityStatefields.AUTHORITY_PUBLICATIONphase;OWNERSHIP_CAPTUREis observable only after durable commit and re-read.MoveFileExWwithREPLACE_EXISTING | WRITE_THROUGH.Files include test-installed-windows-app.ps1, cleanup-installed-windows-app.ps1, and supervisor fixtures/tests.
Validation:
Detailed Logs:
01a05f02-5b3c-77b0-a705-210ff6bbb096Log files stored at:
/tmp/claude-logs/issue-2052-2026-09-01T22-20-55-789Z-conversation.json/tmp/claude-logs/issue-2052-2026-09-01T22-20-55-789Z-output.txtLatest Conversation Messages
This PR was created automatically by ProPR after processing issue #2052.
💡 Need changes?
Comment on this PR to request refinements — the AI agent monitors comments and will update the implementation based on your feedback. Keep iterating until you're satisfied!