[2053 by GPT-5.6 Sol] Make Windows cleanup-controller protocol complete and invocation-attributed - #2057
Conversation
…ol complete Implemented by ProPR AI using gpt-5.6-sol model. Implementation completed successfully.
|
Ultrafix follow-up on exact head bb0a012. Preserve the controller ownership/invocation framing and fix these three independently reproduced blockers:
Run focused/static tests and both native Windows architectures. Keep exactly one terminal line, fixed stderr/exit framing, durable controller-owned evidence, and bounded descendant cleanup. Report the exact new head. |
|
✅ Applied the requested follow-up changes in commit a72c081 Summary of ChangesImplemented the three follow-up fixes:
Validation:
Per instruction, no commit was created. Current exact HEAD remains 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
Implemented the three follow-up fixes: - Bounded Job Object accounting quiescence before classifying/terminating an active tree. - Deterministic before-startup and after-startup cancellation coverage with exact invocation attribution. - Exact protocol status/exit mapping with positive and negative regression fixtures. Validation: - Desktop tests: 177 passed, 6 platform skips. - Release workflow tests: 23 passed. - `git diff --check`: passed. - Native Windows x64/ARM64 could not run from this Linux-only worktree. Per instruction, no commit was created. Current exact HEAD remains `bb0a012b13c47b5fbd1228c1fd4df75979c3033f`; the automation must report the new head after committing these changes. PR: #2057 Comment by: @integry (ID: 5501268411) Model: gpt-5.6-sol
|
Correct only the exact native PowerShell parser failure on head a72c081. Both Windows x64 job 100052136488 and ARM64 job 100052136470 fail before tests at test-installed-windows-app-supervisor.ps1 line 1514 because the interpolated string contains |
|
✅ Applied the requested follow-up changes in commit 331085d Summary of ChangesCorrected only the parser failure in test-installed-windows-app-supervisor.ps1: ":LIFECYCLE:${expectedLifecycle}:"Validation:
Per instruction, I did not commit. Current HEAD remains 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
…s-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-01T22-35-57/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:1514):
Corrected only the parser failure in [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-01T22-35-57/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:1514):
```powershell
":LIFECYCLE:${expectedLifecycle}:"
```
Validation:
- Official PowerShell parser: passed.
- Newly added block scan for similar unbraced interpolation: passed.
- `git diff --check`: passed.
- Diff: one insertion, one deletion; no behavior or assertions changed.
- Native Windows x64/ARM64 focused tests could not run on this Linux x64 host; they require the post-commit CI runners.
Per instruction, I did not commit. Current HEAD remains `a72c0814a1cf4fe6db1ffd59a7d9d309c7b8fdf7`; the exact new head will be assigned by the system’s automatic commit.
PR: #2057
Comment by: @integry (ID: 5501350657)
Model: gpt-5.6-sol
|
Ultrafix the deterministic native failure on exact head 331085d. Both Windows x64 job 100053705828 and ARM64 job 100053706106 pass FIXED_PROTOCOL, then fail in Test-WorkflowCleanupProtocolStateMachine at ONE_LINE_STARTUP because the diagnostic does not contain the expected fixed OBSERVED:STARTUP category. The current assertion hides the actual bounded diagnostic. First make every state-machine assertion failure append only the already fixed, invocation-attributed Get-WorkflowCleanupProtocolMismatchDiagnostic value; it is bounded and path-free, but reassert no dummy installer/path is present before including it. Then reproduce and correct the underlying capture/lifecycle semantics. ONE_LINE_STARTUP emits one complete exact STARTUP:READY line plus CRLF and exits 125, so after bounded stream drain it must deterministically report OBSERVED:STARTUP, LINE_COUNT:1, LIFECYCLE:EXITED, TREE_TERMINATION:NOT_REQUIRED, STARTUP_CLASS:READY, LINE_NUMBER:1. Do not loosen the expected category or accept a terminal record. If asynchronous drain/exit ordering overwrites a valid complete startup category, fix the ordering under the existing bound. Preserve the exact status-to-exit mapping, bounded post-exit Job Object quiescence, cancellation before/after startup, two-line success protocol, fixed output, and production authority. Run the complete focused supervisor state-machine test on both Windows x64 and ARM64, not only the parser. Report the actual pre-fix fixed diagnostic, root cause, and exact new head. |
|
✅ Applied the requested follow-up changes in commit 2d8532d Summary of ChangesImplemented the ultrafix in test-installed-windows-app-supervisor.ps1. The pre-fix failing path resolves to: Root cause: immediate fixtures inherited a 250 ms deadline, racing native Changes:
Validation:
Native Windows x64/ARM64 execution cannot be launched from this Linux worktree without committing/pushing, which the instructions prohibit. The uncommitted base remains 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
…ervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-01T22-44-15/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:1187). Implemented the ultrafix in [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-01T22-44-15/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:1187). The pre-fix failing path resolves to: ```text PROPR_WORKFLOW_CLEANUP_FIXTURE:PROTOCOL_MISMATCH:INVOCATION:PROTOCOL_REGRESSION:OBSERVED:NONE:LINE_COUNT:0:STDERR_COUNT:0:PROCESS_EXIT:125:LIFECYCLE:TIMEOUT_BEFORE_STARTUP:TREE_TERMINATION:COMPLETE:STARTUP_CLASS:NONE:LINE_NUMBER:0 ``` Root cause: immediate fixtures inherited a 250 ms deadline, racing native `pwsh` startup. Additionally, clean-exit classification could proceed to Job Object accounting before bounded stream drain had stabilized capture state. Changes: - Immediate protocol fixtures now use the existing bounded 1,000 ms window; deliberate timeout/tree-race fixtures remain at 250 ms. - Clean exits drain streams before post-exit Job Object quiescence and snapshot the fixed exit first. - `ONE_LINE_STARTUP` asserts the complete required tuple. - State-machine mismatch assertions append the diagnostic only after proving it is path-free and exactly reproducible through `Get-WorkflowCleanupProtocolMismatchDiagnostic`. Validation: - PowerShell parser: passed. - One-line capture: `STARTUP|1|125|READY|1`. - Desktop suite: 177 passed, 6 skipped. - Release workflow: 23 passed. - `git diff --check`: passed. Native Windows x64/ARM64 execution cannot be launched from this Linux worktree without committing/pushing, which the instructions prohibit. The uncommitted base remains `331085db6baf3ffca345eaaa6261bb92e85f5f09`; the exact new head will be produced by the system’s automatic commit. PR: #2057 Comment by: @integry (ID: 5501424376) Model: gpt-5.6-sol
|
Final deterministic timeout-fixture correction on exact head 2d8532d. Both native Windows x64 job 100057584487 and ARM64 job 100057584465 now pass FIXED_PROTOCOL and ONE_LINE_STARTUP, then fail identically at TIMEOUT_AFTER_STARTUP. The newly exposed fixed diagnostic is OBSERVED:NONE, LINE_COUNT:0, PROCESS_EXIT:125, LIFECYCLE:TIMEOUT_BEFORE_STARTUP, TREE_TERMINATION:COMPLETE, STARTUP_CLASS:NONE, LINE_NUMBER:0. The case is still given only 250ms, which is shorter than native pwsh startup; production correctly classifies what it observed, so the fixture expectation is nondeterministic. Keep 250ms for TIMEOUT_BEFORE_STARTUP and deliberate stream-race cases. Give TIMEOUT_AFTER_STARTUP a separate bounded startup-capable window, preferably using the existing capture startup signal/phase so the fixture proves its complete STARTUP:READY record was observed before the timeout countdown/assertion; otherwise use the existing 5-second after-startup bound already used by the cancellation matrix and explicitly assert STARTUP/1/READY/1 before timeout classification. Do not relabel NONE as STARTUP, weaken capture rules, or change production timeout semantics. Retain the anchored path-free diagnostic validation, ONE_LINE exact proof, status-to-exit mapping, Job Object quiescence, and cancellation matrix. Run the entire supervisor state-machine test through its final PASSED marker on both x64 and ARM64, not just the corrected case, and report the exact new head. |
|
✅ Applied the requested follow-up changes in commit 25e00ef Summary of ChangesImplemented the deterministic timeout-fixture correction in test-installed-windows-app-supervisor.ps1:
Validation:
Native x64/ARM64 final markers could not be run because this environment is Linux x64 without PowerShell. Per instruction, no commit was created; current HEAD remains 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
… [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-01T22-58-22/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:422): Implemented the deterministic timeout-fixture correction in [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-01T22-58-22/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:422): - Waits up to five seconds for the capture’s complete startup signal before starting the 250 ms after-startup countdown. - Explicitly asserts `OBSERVED:STARTUP`, `LINE_COUNT:1`, `STARTUP_CLASS:READY`, and `LINE_NUMBER:1`. - Applies the same startup synchronization to the tree-termination-failure case. - Leaves production semantics, cancellation matrix, Job Object handling, and other 250 ms fixtures unchanged. Validation: - Desktop suite: 177 passed, 6 platform skips. - Release workflow: 23 passed. - `git diff --check`: passed. Native x64/ARM64 final markers could not be run because this environment is Linux x64 without PowerShell. Per instruction, no commit was created; current HEAD remains `2d8532d415b64c9cee4cd0822b9815ddc4f1f9db`. The automated commit/Windows CI must provide the new head and native final markers. PR: #2057 Comment by: @integry (ID: 5501554980) Model: gpt-5.6-sol
|
Final deterministic stream-drain fixture correction on exact head Both native Windows x64 job Make the narrow test-fixture correction:
|
|
✅ Applied the requested follow-up changes in commit 16a980f Summary of ChangesImplemented the narrow fixture correction in test-installed-windows-app-supervisor.ps1:
Validation:
Native Windows execution is unavailable locally. CI must show 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
…d-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-01T23-06-48/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:1514): Implemented the narrow fixture correction in [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-01T23-06-48/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:1514): - `STREAM_DRAIN_RACE` retains its 250 ms window but now uses `BeginTimeoutAfterStartup`. - Added exact assertions for terminal observation, 2 lines, zero stderr, exit 125, `READY` startup, terminal line 2, `ACTIVE_TREE_AFTER_EXIT`, and complete tree termination. - `TIMEOUT_BEFORE_STARTUP` remains launch-relative at 250 ms. - No production files were changed. Validation: - Full desktop suite: 177 passed, 6 platform skips. - Release-workflow contract: 23 passed. - `git diff --check`: passed. Native Windows execution is unavailable locally. CI must show `PROPR_WINDOWS_SUPERVISOR_CONTROLLER_STATE_MACHINE:BOUNDED:PASSED` on both x64 and ARM64 before acceptance. No commit was created. PR: #2057 Comment by: @integry (ID: 5501660217) Model: gpt-5.6-sol
|
Ultrafix the real post-startup production protocol failure on exact head Both native Windows x64 job
They then fail identically at the real This is not a drain or timeout issue: capture Finish completed, the Job Object is quiescent, and the wrapper genuinely exits 125 after a valid startup record without the mandatory terminal. The workflow-cleanup body normally emits the terminal at RESULT_EMISSION, but its emission catch currently calls Set-CaughtControllerFailure and exits 125 without any terminal. Make an evidence-driven narrow production correction:
|
|
✅ Applied the requested follow-up changes in commit db7f411 Summary of ChangesImplemented the narrow post-startup protocol correction on head Key changes:
Validation passed:
Native Windows x64 and ARM64 execution remains pending CI after the system commits these changes; I did not claim those jobs passed locally. 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
|
✅ Applied the requested follow-up changes in commit 4af5b06 Summary of ChangesImplemented the narrow semantic attribution fix on head Changed:
Preserved:
Validation run:
Not run:
🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
|
CI failed: Validate unsigned win32-arm64 package Please investigate and fix this CI failure.
Failure evidence
|
|
CI failed: Validate unsigned win32-x64 package Please investigate and fix this CI failure.
Failure evidence
|
|
Queue this evidence-only attribution split after the active semantic digest task; do not overlap it and do not change the native producer yet. Fresh x64 job 100346022992 on 30edcce passed FIXED_PROTOCOL, BOUNDED, TOTAL, PRE_EXISTING_AUTHORITIES, and APP_PATHS_PRE_EXISTING, then still failed at broad On the active task's resulting exact head, split REGRESSION_VALUE_SETUP into fixed, total, secret-free suboperations that distinguish at minimum:
Keep exact paths/names/bytes/native text out of diagnostics. Preserve the current fixture-only RegSetValueExW implementation unchanged until native x64 and ARM64 converge on a producer predicate. Add executable attribution tests, then rerun both real native jobs. Preserve production code and lock entries. Do not merge. |
…edcce07e2ca415aef6b30a450bfc44ab53b1d2`. No commit made. Implemented the narrow semantic attribution fix on head `30edcce07e2ca415aef6b30a450bfc44ab53b1d2`. No commit made. Changed: - [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-02T17-11-35/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1): moved Initialize digest validity inside `BASELINE_DIGEST`; changed direct `BASELINE_DIGEST` / `FINAL_BASELINE_DIGEST` assertions to generic fixture throws; preserved distinct recovery collision and rename-failure coverage. - Added executable focused regressions for digest-invalid and equality-failure paths, asserting exact emitted tokens are `BASELINE_DIGEST` / `FINAL_BASELINE_DIGEST` and not broad `HKCU_BASELINE_STATE`. - [release-workflow.test.ts](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-02T17-11-35/apps/desktop/src/release-workflow.test.ts): updated static contract checks for the corrected semantics. Preserved: - Production cleanup/controller/runtime code unchanged. - Native `RegSetValueExW` fixture producer unchanged. - `package-lock.json` unchanged; `qs` / `fast-uri` untouched. Validation run: - `npx tsx --test apps/desktop/src/release-workflow.test.ts` passed. - `npm run test -w @propr/desktop` passed: 177 passed, 6 skipped. - `npm run audit:runtime` passed, 0 vulnerabilities. - `npm run desktop:audit:packaging` passed, 0 vulnerabilities. - `git diff --check` passed. - Digest-wrapper scan passed: 13 digest wrapper candidates checked, none contained `Get-HkcuFixtureBoundaryDiagnostic`. Not run: - Real native Windows x64/ARM64 supervisor/package jobs. This container is Linux and has no `pwsh`; those jobs require the committed remote ref in `desktop-release-guard.yml`, and the task explicitly says not to commit. PR: #2057 Comment by: @integry (ID: 5513411134) Model: gpt-5.5
|
ProPR follow-up on exact head 4af5b06. Please close the two remaining exact Windows fixture proof gaps without changing production cleanup behavior or the canonical lockfile:
Keep the already-correct generic assertion attribution, collision/rename preservation, bounded cleanup, and exact head scope. Run static tests plus native x64 and ARM64 and report the first fixed failing token if either native gate fails. |
|
✅ Applied the requested follow-up changes in commit 54dddc8 Summary of ChangesImplemented the two requested fixture-only follow-ups on exact head Changed:
Validation:
Native x64/ARM64 gates were not run locally: this container is Linux and has no 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
|
CI failed: Validate unsigned win32-x64 package Please investigate and fix this CI failure.
Failure evidence
|
|
CI failed: Validate unsigned win32-arm64 package Please investigate and fix this CI failure.
Failure evidence
|
|
CI failed: Run Full Test Suite Please investigate and fix this CI failure.
Failure evidence
|
Full Test Suite ResultsValidation failed during: Full test suite.
View Test Output |
…act head `4af5b0609b1a53653aace43280ac9201081390cf`. Implemented the two requested fixture-only follow-ups on exact head `4af5b0609b1a53653aace43280ac9201081390cf`. Changed: - [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-02T17-27-40/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:1727): recovery relocation now computes the moved-back `BackupPath` digest through `Get-HkcuFixtureRegistryDigest` and requires exact `BaselineDigest` equality before rethrowing the saved baseline failure. If proof fails, it reports `RECOVERY_RELOCATE`. - [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-02T17-27-40/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:5951): split `REGRESSION_VALUE_SETUP / REGISTRY_VALUE` into fixed sub-operations for root key setup, value-kind setup, native `REG_NONE` write with `NATIVE_RETURN_CODE`, nested key setup, and nested value setup. - [release-workflow.test.ts](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-02T17-27-40/apps/desktop/src/release-workflow.test.ts:1133): updated static regressions to require the new digest proof and reject the old broad setup attribution. Validation: - `npx tsx --test apps/desktop/src/release-workflow.test.ts` passed. - `npm run test -w @propr/desktop` passed: 177 pass, 6 platform skips. - `git diff --check` passed. Native x64/ARM64 gates were not run locally: this container is Linux and has no `pwsh`, so there is no native Windows failing token to report from this environment. `package-lock.json` was not changed. PR: #2057 Comment by: @integry (ID: 5513619014) Model: gpt-5.5
|
Independent follow-up on exact head 54dddc8. The production recovery change and fixed setup split audit clean, but the new post-recovery mismatch regression injects its bad digest at the wrong read. Its mock returns Correct only the regression fixture:
Preserve the audited production recovery code, all five fixed REGRESSION_VALUE_SETUP sub-operations, native producer, lockfile, and total cleanup. Run static tests and let fresh native x64/ARM64 identify the real first setup token. |
|
✅ Applied the requested follow-up changes in commit b911a90 Summary of ChangesImplemented the follow-up fixture fix on exact head Changed:
Validation:
🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
|
CI failed: Validate unsigned win32-x64 package Please investigate and fix this CI failure.
Failure evidence
|
…835e8847195f1c7d97716d5d2cadc6bf6e`. Implemented the follow-up fixture fix on exact head `54dddc835e8847195f1c7d97716d5d2cadc6bf6e`. Changed: - [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-02T17-39-17/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1): recovery proof mock now delegates the first `BackupPath` digest read, returns the bad digest only on the second `BackupPath` read, then delegates later reads. It asserts exact call count/order and the `RECOVERY_RELOCATE` diagnostic, restores the original function, then proves the retained backup’s real digest equals the original baseline. - [release-workflow.test.ts](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-02T17-39-17/apps/desktop/src/release-workflow.test.ts): tightened static coverage for that exact fixture behavior. Validation: - `git diff --check` passed. - `npx tsx --test apps/desktop/src/release-workflow.test.ts` passed: 23/23. - `npm --workspace apps/desktop test -- src/release-workflow.test.ts` passed the desktop suite: 177 passed, 6 skipped. - Native Windows x64/ARM64 were not run locally because `pwsh` is not installed in this Linux environment. PR: #2057 Comment by: @integry (ID: 5513775588) Model: gpt-5.5
|
CI failed: Validate unsigned win32-arm64 package Please investigate and fix this CI failure.
Failure evidence
|
|
CI failed: Validate unsigned win32-x64 package Please investigate and fix this CI failure.
Failure evidence
|
|
Native follow-up on exact head b911a90. Fresh hosted x64 job 100357573048 and ARM64 job 100357573049 converge after all prior markers at: This proves the native REG_NONE writer is not the current first failure; one conventional .NET registry value-kind setup call fails earlier. Implement attribution-only refinement:
Preserve the audited recovery digest proof, five outer setup tokens, collision/rename semantics, and recoverable bytes. |
|
✅ Applied the requested follow-up changes in commit 7b8dcfc Summary of ChangesImplemented the attribution-only split on exact head Changed:
Validation:
Native x64/ARM64 were not rerun: this Linux host has no 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
…90f...`. Implemented the attribution-only split on exact head `b911a90f...`. Changed: - [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-02T17-53-02/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:2355): replaced broad `REGRESSION_VALUE_KIND_SETUP` allowlist entry with fixed tokens for `KEY_OPEN`, `DEFAULT_STRING`, `STRING`, `EXPAND_STRING`, `BINARY`, `DWORD`, `QWORD`, `MULTI_STRING`. - [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-02T17-53-02/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:3793): updated attribution-totality behavioral cases for every exact token. - [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-02T17-53-02/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:6022): split the setup so `Get-Item` is under `REGRESSION_VALUE_KIND_KEY_OPEN / REGISTRY_PATH`, and each existing `.SetValue(...)` call is under its own fixed `REGISTRY_VALUE` token. No `SetValue` arguments/types/values or native `REG_NONE` code changed. - [release-workflow.test.ts](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-02T17-53-02/apps/desktop/src/release-workflow.test.ts:642): updated static regressions to require the exact tokens and reject the old broad `REGRESSION_VALUE_KIND_SETUP`. Validation: - `npm --workspace @propr/desktop exec -- tsx --test src/release-workflow.test.ts` passed. - `npm --workspace @propr/desktop test` passed: 177 passed, 6 skipped. - `git diff --check` passed. Native x64/ARM64 were not rerun: this Linux host has no `pwsh`, and hosted native Actions cannot exercise these uncommitted changes without committing/pushing, which the request explicitly forbids. New first converged native token is therefore not available from this run. PR: #2057 Comment by: @integry (ID: 5513954655) Model: gpt-5.5
|
CI failed: Validate unsigned win32-arm64 package Please investigate and fix this CI failure.
Failure evidence
|
|
CI failed: Validate unsigned win32-x64 package Please investigate and fix this CI failure.
Failure evidence
|
|
Follow-up on exact head
Make the narrow fixture-only writable-handle correction:
|
|
✅ Applied the requested follow-up changes in commit fd333cc Summary of ChangesImplemented the narrow fixture-only writable-handle correction. Changed:
Validation run:
I could not run native PowerShell/x64/ARM64 validation here because 🤖 Implementation Details
Undo Changes • View Task Execution 💡 ProPR Slash Commands
🤖 Generated by ProPR |
…ion. Implemented the narrow fixture-only writable-handle correction. Changed: - Added bounded HKCU supervisor fixture writable opener in [test-installed-windows-app-supervisor.ps1](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-02T18-13-40/apps/desktop/scripts/test-installed-windows-app-supervisor.ps1:1594), restricted to canonical `Registry::HKEY_CURRENT_USER\Software\ProPRSupervisorFixture\...` paths. - Updated `Set-HkcuFixtureBoundaryValueKinds` to use the explicit writable key for all existing value-kind writes and the native REG_NONE writer, with deterministic `Dispose()` in `finally`. - Routed later HKCU fixture setup `.SetValue` sites through the helper where paths are under `ProPRSupervisorFixture`; for `Software\ProPR\Desktop`, switched to `New-ItemProperty` with explicit `String`/`DWord` property types. - Added focused static coverage in [release-workflow.test.ts](/tmp/git-processor/worktrees/integry/propr/pr-2057-followup-2026-09-02T18-13-40/apps/desktop/src/release-workflow.test.ts:1183) for accepted/rejected fixture paths, writable `OpenSubKey(..., $true)`, disposal, and prevention of the old read-view `.SetValue` pattern. Validation run: - `npx tsx --test apps/desktop/src/release-workflow.test.ts` passed. - `npx tsc --noEmit --project apps/desktop/tsconfig.json` passed. - `git diff --check` passed. I could not run native PowerShell/x64/ARM64 validation here because `pwsh` is not installed in this Linux container. Per instruction, I did not commit; current checked-out HEAD remains `7b8dcfccc3426d2cb1dd6cc941908979ffe6ff2b` with the two intended files modified. PR: #2057 Comment by: @integry (ID: 5514216622) Model: gpt-5.5
|
CI failed: Validate unsigned win32-x64 package Please investigate and fix this CI failure.
Failure evidence
|
|
CI failed: Validate unsigned win32-arm64 package Please investigate and fix this CI failure.
Failure evidence
|
AI Implementation Summary
Closes #2053
Branch:
2053/gpt-5.6-sol-make-windows-cleanup-cont-20260901-2205-5eoCommits: ✅ Changes committed (bb0a012)
AI Processing Completed
Execution Details:
Summary:
Implemented issue #2053.
Key changes:
STARTUPandTERMINALrecords in the cleanup controller body.Validation:
Detailed Logs:
01a05f02-6eda-7673-906d-a30b64c1c5feLog files stored at:
/tmp/claude-logs/issue-2053-2026-09-01T22-21-45-958Z-conversation.json/tmp/claude-logs/issue-2053-2026-09-01T22-21-45-958Z-output.txtLatest Conversation Messages
This PR was created automatically by ProPR after processing issue #2053.
💡 Need changes?
Comment on this PR to request refinements — the AI agent monitors comments and will update the implementation based on your feedback. Keep iterating until you're satisfied!