Repository navigation
Bump LLVM to f1873b3b814b - #441
Merged
Merged
Conversation
Two upstream changes need adjustments on our side: llvm/llvm-project@8ffc25602651 moved the bufferization external models out of each dialect's Transforms library into one MLIR<Dialect><Interface>Impl library per model. Its migration guide requires out-of-tree callers of a register*ExternalModels function to link the corresponding new library, so the eleven libraries that back the registrations in getDialectRegistry() are added to MLIR_DIALECT_LIBS. The Linalg and Func models stay in MLIRBufferizationTransforms for now; upstream plans to move those too. llvm/llvm-project@4d787f35aaba compiles the MLIR dump() methods only under !NDEBUG || LLVM_ENABLE_DUMP. The OpenVINO GPU plugin still calls ModuleOp::dump(), so a release build of openvino_intel_gpu_mlir_obj fails with error: no member named 'dump' in 'mlir::ModuleOp' Build LLVM with LLVM_ENABLE_DUMP=ON as a temporary workaround. The upstream migration is to call print() instead; drop the flag once the OpenVINO caller does that. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
AndreyPavlenko
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two upstream changes need adjustments on our side.
Bufferization external models moved into their own libraries.
llvm/llvm-project#236459 took the
BufferizableOpInterface,BufferDeallocationOpInterfaceandAllocationOpInterfaceexternal models outof each dialect's Transforms library and gave each one an
MLIR<Dialect><Interface>Impllibrary. Its migration guide requiresout-of-tree callers of a
register*ExternalModelsfunction to link thecorresponding new library. Because
cmake/mlir.cmakekeeps a curatedMLIR_DIALECT_LIBSlist rather than the full list fromMLIRConfig.cmake, thenew libraries do not arrive on their own and the link fails with eleven
undefined references, for example:
The eleven libraries that back the registrations in
getDialectRegistry()areadded to that list. The Linalg and Func models stay in
MLIRBufferizationTransformsfor now; upstream plans to move those too, whichwill need the same treatment.
MLIR
dump()is now debug-only. llvm/llvm-project#233398 compiles the MLIRdump()methods only under!NDEBUG || LLVM_ENABLE_DUMP. The OpenVINO GPUplugin still calls
ModuleOp::dump(), so a release build ofopenvino_intel_gpu_mlir_objfails with:scripts/build.shnow builds LLVM withLLVM_ENABLE_DUMP=ONas a temporaryworkaround. The upstream migration is to call
print()instead; the flagshould be dropped once the OpenVINO caller does that.
🤖 Generated with Claude Code