[SECURITY] i2c: prevent RX FIFO buffer overflow - #84
Merged
Merged
Conversation
xiaolusu
requested review from
kwd-doodling,
lifenggitacc and
likongintel
as code owners
September 18, 2026 02:00
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new error path references nonexistent status fields and cannot compile.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds RX FIFO bounds validation to prevent out-of-bounds writes during I2C transfers.
Changes:
- Validates FIFO data against pending commands and buffer capacity.
- Aborts inconsistent transfers.
| File | Description |
|---|---|
bsp_sedi/drivers/i2c/sedi_i2c_dw_apb_200a.c |
Adds receive validation and error handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Validate the RX FIFO level against pending read commands and the remaining receive buffer before copying data. Abort inconsistent transfers to prevent out-of-bounds writes. Signed-off-by: Xiaolu Sun <xiaolu.sun@intel.com>
likongintel
approved these changes
Sep 21, 2026
kwd-doodling
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate the RX FIFO level against pending read commands and the remaining receive buffer before copying data. Abort inconsistent transfers to prevent out-of-bounds writes.