Repository navigation
[SYCL] Deprecate -fsycl-targets=spir64_gen in favor of intel_gpu_<arch> #23441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
srividya-sundaram
wants to merge
27
commits into
intel:sycl
Choose a base branch
from
srividya-sundaram:sycl-deprecate-spir64-gen
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+382
−286
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
98012b2
[SYCL][E2E] Select Intel GPU AOT targets via gpu_aot_target
srividya-sundaram 7569eea
[SYCL][Driver] Deprecate -fsycl-targets=spir64_gen
srividya-sundaram 6b5c476
Merge branch 'sycl' into sycl-deprecate-spir64-gen
srividya-sundaram 2a6c3a3
[SYCL] Address review comments for spir64_gen deprecation
srividya-sundaram 8c73223
[SYCL][E2E] Fix comment formatting in aot_object_no_symbols.cpp
srividya-sundaram 905a197
[SYCL][E2E] Exclude Gen12 from the Windows build-only gpu_aot_target …
srividya-sundaram 10bb403
[Clang][OffloadBundler] Match the target ID of SYCL bundle entry IDs
srividya-sundaram 29293ce
[SYCL][E2E] Fix AOT tests that relied on spir64_gen images running on…
srividya-sundaram bb2a27a
[SYCL][E2E] Accept one abstract module per architecture in simple_ker…
srividya-sundaram 3560b03
[SYCL] Only use AOT images built for the device's architecture
srividya-sundaram 08d46ad
[SYCL][E2E] Add a SPIR-V image to the AOT block of test_cache_jit_aot…
srividya-sundaram f4a274d
[SYCL][E2E] Set the build-only gpu_aot_target from the CI workflows
srividya-sundaram b3ef500
[SYCL][Doc] Describe spir64_gen deprecation in terms of --offload-new…
srividya-sundaram 0dff57c
[SYCL][E2E] Clarify why build_log.cpp is unsupported with the new off…
srividya-sundaram 424490c
[SYCL][E2E] Keep gpu_aot_target_opts for extra AOT options
srividya-sundaram ebc840f
[SYCL][clang-linker-wrapper] Wrap all architectures in one module for…
srividya-sundaram bc79849
[SYCL] Check the compile_target in compatibleWithDevice
srividya-sundaram fd715b0
Merge branch 'sycl' into sycl-deprecate-spir64-gen
srividya-sundaram 5c2cc96
[SYCL][E2E] Remove the stale XFAIL from the AddressSanitizer AOT GPU …
srividya-sundaram 4fdb976
[SYCL][E2E] Build bfloat16_example_aot.cpp for gpu_aot_target
srividya-sundaram 0c428da
[SYCL][Driver] Rename err_drv_sycl_spir64_gen_new_driver to err_drv_n…
srividya-sundaram 548e6c8
Merge branch 'sycl' into sycl-deprecate-spir64-gen
srividya-sundaram af84095
Merge branch 'sycl' into sycl-deprecate-spir64-gen
srividya-sundaram 4e9ca41
[SYCL][Doc] Document intel_gpu_<arch> instead of spir64_gen in the us…
srividya-sundaram 0af2c32
[SYCL][Driver] Name the SYCL target in the spir64_gen check and test …
srividya-sundaram fadb0a3
[SYCL][Driver] Say spir64_gen will be removed with the old offloading…
srividya-sundaram f1d6482
Merge branch 'sycl' into sycl-deprecate-spir64-gen
srividya-sundaram File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| // Test SYCL -foffload-fp32-prec-div | ||
|
|
||
| // RUN: %clang -### -fsycl --offload-new-driver --sysroot=%S/Inputs/SYCL \ | ||
| // RUN: -fsycl-targets=spir64_gen -foffload-fp32-prec-div %s 2>&1 \ | ||
| // RUN: -fsycl-targets=intel_gpu_pvc -foffload-fp32-prec-div %s 2>&1 \ | ||
| // RUN: | FileCheck -check-prefix=AOT %s | ||
|
|
||
| // RUN: %clang -### -fsycl --offload-new-driver --sysroot=%S/Inputs/SYCL \ | ||
| // RUN: -foffload-fp32-prec-div %s 2>&1 \ | ||
| // RUN: | FileCheck -check-prefix=JIT %s | ||
|
|
||
| // AOT: llvm-offload-binary{{.*}} "--image=file={{.*}}.bc,triple=spir64_gen-unknown-unknown,arch={{.*}},kind=sycl,compile-opts=-options -ze-fp32-correctly-rounded-divide-sqrt{{.*}}" | ||
| // AOT: llvm-offload-binary{{.*}} "--image=file={{.*}}.bc,triple=spir64_gen-unknown-unknown,arch={{.*}},kind=sycl,compile-opts={{.*}}-options -ze-fp32-correctly-rounded-divide-sqrt{{.*}}" | ||
|
|
||
| // JIT: llvm-offload-binary{{.*}} "--image=file={{.*}}.bc,triple=spir64-unknown-unknown,arch={{.*}}compile-opts={{.*}}-foffload-fp32-prec-div" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| // Test SYCL -foffload-fp32-prec-sqrt | ||
|
|
||
| // RUN: %clang -### -fsycl --offload-new-driver --sysroot=%S/Inputs/SYCL \ | ||
| // RUN: -fsycl-targets=spir64_gen -foffload-fp32-prec-sqrt %s 2>&1 \ | ||
| // RUN: -fsycl-targets=intel_gpu_pvc -foffload-fp32-prec-sqrt %s 2>&1 \ | ||
| // RUN: | FileCheck -check-prefix=AOT %s | ||
|
|
||
| // RUN: %clang -### -fsycl --offload-new-driver --sysroot=%S/Inputs/SYCL \ | ||
| // RUN: -foffload-fp32-prec-sqrt %s 2>&1 \ | ||
| // RUN: | FileCheck -check-prefix=JIT %s | ||
|
|
||
| // AOT: llvm-offload-binary{{.*}} "--image=file={{.*}}.bc,triple=spir64_gen-unknown-unknown,arch={{.*}},kind=sycl,compile-opts=-options -ze-fp32-correctly-rounded-divide-sqrt{{.*}}" | ||
| // AOT: llvm-offload-binary{{.*}} "--image=file={{.*}}.bc,triple=spir64_gen-unknown-unknown,arch={{.*}},kind=sycl,compile-opts={{.*}}-options -ze-fp32-correctly-rounded-divide-sqrt{{.*}}" | ||
|
|
||
| // JIT: llvm-offload-binary{{.*}} "--image=file={{.*}}.bc,triple=spir64-unknown-unknown,arch={{.*}}compile-opts={{.*}}-foffload-fp32-prec-sqrt" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.