Skip to content

[DeviceASAN] Accept lower Shared USM addresses on PVC #23452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhaomaosu wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[DeviceASAN] Accept lower Shared USM addresses on PVC #23452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4caf37e
[DeviceASAN] Accept lower Shared USM addresses on PVC
zhaomaosu Oct 12, 2026
e2d77f9
Merge branch 'sycl' into asan-accept-low-addr
zhaomaosu Oct 20, 2026
fd9ed06
resolve comment
zhaomaosu Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sycl/test-e2e/AddressSanitizer/misaligned/misalign-long.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
// RUN: %{run} not --crash %t2.out 2>&1 | FileCheck %s
// RUN: %{build} %device_asan_flags -O2 -g -o %t3.out
// RUN: %{run} not --crash %t3.out 2>&1 | FileCheck %s
// An unlimited stack selects Linux's legacy mmap layout, allowing Shared USM
// addresses below the usual PVC range starting at 0x700000000000.
// RUN: %if arch-intel_gpu_pvc %{ %{run} not --crash sh -c 'ulimit -s unlimited && exec "$@"' sh %t3.out 2>&1 | FileCheck %s %}
#include <iostream>
#include <sycl/detail/core.hpp>
#include <sycl/usm.hpp>
Expand Down
9 changes: 8 additions & 1 deletion unified-runtime/source/loader/layers/sanitizer/sanitizer_common/sanitizer_allocator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,14 @@ void validateSharedUSM([[maybe_unused]] uptr Allocated,
[[maybe_unused]] DeviceType DeviceType) {
switch (DeviceType) {
case DeviceType::GPU_PVC:
assert((Allocated >> 44) == 0x7);
// FIXME: ASan supports all lower 47-bit addresses, including Shared USM
// placed below 0x700000000000 by Linux. MSan/TSan discard more address
// bits, so relaxing their checks could alias shadow memory. They can still
// hit this assertion until their shadow mappings support the wider range.
if (getContext()->enabledType == SanitizerType::AddressSanitizer)
assert((Allocated >> 47) == 0);
else
assert((Allocated >> 44) == 0x7);
break;
default:
break;
Expand Down
Loading