Repository navigation
Conversation
Add the sycl::ext::oneapi::property::queue::priority property and the
sycl::ext::oneapi::info::device::priority_range descriptor.
Numeric priorities are clamped to the device range and passed to UR via
ur_exp_queue_priority_properties_t. The pre-defined priorities keep
using the UR priority flags, which adapters map to the ends of the
priority range. Devices without priority levels report {0, 0}.
Also fix queue property validation accepting dataless deprecated aliases
as properties with data, which made their kinds collide.
Assisted-By: Claude
Replace the supported extension document with the proposed revision 2, which is now implemented, and remove the proposed document. Only the status section and the copyright years are changed. Assisted-By: Claude
Changes to the moved revision 2 text and the reasons for them:
- Add priority::get_priority(). Without a getter the value of the
property can't be read back with queue::get_property, and other
properties with data, such as compute_index, provide one.
- Document the priority constructor and get_priority in separate member
blocks, as other extension documents do.
- Add a "Conflicting priorities" section. Revision 1 forbids combining
the pre-defined priorities, but revision 2 doesn't specify combining
them with the numeric priority. Extend the existing errc::invalid rule
to all priority properties.
- Allow priority_low and priority_high to specify lower and higher
priorities than the default one on devices without numeric priorities,
whose priority_range is {0, 0}. Backends such as CUDA, HIP and Level
Zero v1 keep supporting these hints.
- State that the priority range always contains the default priority 0.
Otherwise priority(0) and priority_normal could be clamped to a
non-default priority.
- Specify that devices without numeric priorities return {0, 0}, so that
priority_range can be queried on any device and clamping to it is
consistent with the default priority.
- Mention in the status note that numeric priorities are only used by
the Level Zero v2 adapter.
- Drop "additional" from the overview, since the document now describes
all properties, and "with fixed numeric values", which doesn't hold
for priority_low and priority_high whose values depend on the device.
Assisted-By: Claude
gmlueck
reviewed
Oct 15, 2026
- Don't distinguish between devices supporting numeric priorities and
devices supporting the pre-defined priorities. Devices without priority
support return {0, 0} from priority_range, so all pre-defined
priorities are 0 there, which follows from the existing wording.
- Delete the status note listing the backends using each kind of
priority.
- Keep the copyright year of the original publication.
- Write the extension against SYCL 2020 revision 12.
Assisted-By: Claude
againull
marked this pull request as draft
October 21, 2026 18:01
againull
marked this pull request as ready for review
October 21, 2026 18:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add implementation and move proposed specification to supported with some required adjustments.
Assisted-By: Claude