Skip to content

[SYCL] Revise Code Snippets in the Specification of the Virtual Function Ext - #23507

Open
HPS-1 wants to merge 2 commits into
intel:syclfrom
HPS-1:virtual_func_doc_fix
Open

HPS-1 wants to merge 2 commits into
intel:syclfrom
HPS-1:virtual_func_doc_fix

Conversation

@HPS-1

@HPS-1 HPS-1 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Mainly fixed 3 things:

  1. namspace syclext = ... should be used instead of using syclext = ... (the later one causes comp errors);
  2. SYCL_EXT_ONEAPI_FUNCTION_PROPERTY macros should come before the virtual keywords;
  3. Kernel properties should be specified using kernel funtors with the get(properties_tag) method, not the deprecated variants of singles_task() which take kernel properties as argument.

Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
@HPS-1
HPS-1 requested a review from a team as a code owner October 15, 2026 14:08
Comment thread sycl/doc/extensions/proposed/sycl_ext_oneapi_virtual_functions.asciidoc Outdated
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants