Repository navigation
[SYCL][Unit] Re-enable MultipleDeviceCacheTest.ProgramRetain - #23553
Open
uditagarwal97 wants to merge 1 commit into
Open
uditagarwal97 wants to merge 1 commit into
uditagarwal97 wants to merge 1 commit into
Conversation
uditagarwal97
marked this pull request as ready for review
October 20, 2026 01:35
uditagarwal97
requested review from
againull
and
a balanced review from Copilot
October 20, 2026 01:35
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow test-only change restores existing coverage with the prerequisite cleanup fix present and no identified defects.
No open issues 🎉
What changed in this PR
Re-enables MultipleDeviceCacheTest.ProgramRetain on Windows following the host-task cleanup fix in #23229, restoring coverage for #21553.
Changes:
- Removes the Windows-only test disablement.
- Leaves test logic and production code unchanged.
| File | Description |
|---|---|
| sycl/unittests/kernel-and-program/MultipleDevsCache.cpp | Enables ProgramRetain on all platforms. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was fixed by #23229 - verified locally. The test failure was due to lingering host task threads spawned by prior tests, draining the host task thread pool in
~UrMock(#23229) removes all such lingering host tasks threads.Fixes #21553