Repository navigation
Conversation
driver diagnostic Signed-off-by: jinge90 <ge.jin@intel.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow test-only cleanup preserves diagnostic checks, with no unresolved issues identified.
No open issues 🎉
What changed in this PR
Simplifies Clang’s SYCL driver diagnostic tests by removing sysroot arguments from commands expected to fail before device-library linking.
Changes:
- Removes sysroot setup from negative-test invocations across eight files.
- Preserves existing diagnostic assertions and leaves production code unchanged.
| File | Description |
|---|---|
| clang/test/Driver/sycl-option-ownership.cpp | Simplifies invalid register-allocation option test. |
| clang/test/Driver/sycl-offload.cpp | Simplifies invalid target and option tests. |
| clang/test/Driver/sycl-offload-jit.cpp | Simplifies invalid image-split value test. |
| clang/test/Driver/sycl-offload-arch-intel-cpu.cpp | Simplifies unsupported architecture tests. |
| clang/test/Driver/sycl-lto.cpp | Simplifies incompatible LTO option test. |
| clang/test/Driver/sycl-host-compiler.cpp | Simplifies host-compiler diagnostic tests. |
| clang/test/Driver/sycl-ftarget-register-alloc-mode.cpp | Simplifies invalid device and allocation-mode tests. |
| clang/test/Driver/sycl-fsyclbin.cpp | Simplifies device-image dependency conflict tests. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some SYCL driver tests aim to test some driver diagnostics, the driver will fail and stop early in these tests, devicelib link will not run, so we can safely remove the sysroot.