Repository navigation
Conversation
Signed-off-by: jinge90 <ge.jin@intel.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test-only changes preserve required fixture lookup, with no unresolved findings.
No open issues 🎉
What changed in this PR
Simplifies SYCL driver tests for AMD and NVIDIA GPUs by removing unnecessary sysroot settings.
Changes:
- Removes sysroot overrides where device libraries are disabled.
- Uses
-ccc-install-dirto retain fixture lookup where needed.
| File | Description |
|---|---|
| clang/test/Driver/sycl-offload-new-driver.cpp | Cleans up sysroot options and preserves CUDA fixture lookup. |
| clang/test/Driver/sycl-nvptx-link.cpp | Replaces required sysroot overrides with install-directory settings. |
| clang/test/Driver/sycl-hip-driver-args.cpp | Removes an unnecessary sysroot override. |
Review effort: Balanced
mdtoguchi
approved these changes
Oct 20, 2026
Contributor
Author
|
Hi, @intel/llvm-gatekeepers |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nogpulib and nocudalib are alias of no-offloadlib, devicelibs are not involved, we can safely remove the sysroot usage.
For other usage of sysroot in these amd, nv tests, we replace them with 'ccc-install-dir'.