Repository navigation
[SYCL][Driver][Test] Clean up sysroot in new offload driver test when input are objects or archives - #23560
Open
jinge90 wants to merge 1 commit into
Open
[SYCL][Driver][Test] Clean up sysroot in new offload driver test when input are objects or archives#23560jinge90 wants to merge 1 commit into
jinge90 wants to merge 1 commit into
Conversation
input are objects or archives Signed-off-by: jinge90 <ge.jin@intel.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The test-only cleanup preserves assertions and removes sysroot settings only where device compilation is not performed.
No open issues 🎉
What changed in this PR
Removes unnecessary sysroot settings from SYCL new-offload-driver tests whose object or archive inputs do not require compile-time device libraries.
Changes:
- Removes sysroot arguments from object-only and archive-input test invocations.
- Preserves existing checks and sysroot settings for source-compilation tests.
| File | Description |
|---|---|
| clang/test/Driver/sycl-spirv-obj.cpp | Removes sysroot from the object-linking test. |
| clang/test/Driver/sycl-option-ownership.cpp | Removes sysroot from object-only option tests. |
| clang/test/Driver/sycl-offload.cpp | Cleans up object-linking and unused-archive tests. |
| clang/test/Driver/sycl-offload-new-driver.cpp | Removes sysroot from the multi-target object-linking test. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devicelib are linked during device compilation phase via -mbuiltin-bitcode-post, some tests for new-offload-driver use .obj or .a file as inputs, so no devicelib linking happens for them, we can safely remove the sysroot usage.