Repository navigation
Relax DIExpression check in dbg-line-column test - #893
Merged
Merged
Conversation
The DW_OP_constu/swap/xderef opcodes are not needed to validate the line/column information checked by this test. The address space is already encoded in the pointer type of the variable, so match any DIExpression to allow removing DW_OP_xderef. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
wenju-he
enabled auto-merge (squash)
October 28, 2026 02:43
cdai2
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DW_OP_constu/swap/xderef opcodes are not needed to validate the line/column information checked by this test. The address space is already encoded in the pointer type of the variable, so match any DIExpression to allow removing DW_OP_xderef.