Repository navigation
ICD loader layer fixes and refactoring - #487
Merged
Merged
Conversation
- Incorporated the official OpenCL layer header. - Updated OpenCL headers to the latest versions. - Moved ICD layer functionality to a dedicated source files. - Fixed symbol used to get the CLIntercept shared library file name. - Added support for loading libraries with deep binding. - Implemented clInitLayerWithProperties. - Added layer exports to Linux shared library. - Ensured layer function pointers were to CLintercept. - Added checks for number of layer entries.
Contributor
Author
Contributor
|
Sure, I'm going to check this |
Contributor
Author
|
Awesome, thanks! Note, as a further improvement, I think we could add support to |
Contributor
Author
|
This has been open for a while, so I am going to go ahead and merge these changes to unblock future progress. I'm still very interested in feedback, especially if something is broken, though, so please feel free to leave comments here (or file a new issue). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR includes some fixes and refactoring when using the OpenCL Intercept Layer as an ICD loader layer:
Testing Done
Tested on Windows and Linux. Verified that recent ICD loaders will load the layer and that call logging and host performance timing work as expected. Also, checked with a slightly older OpenCL ICD loader, and verified that the OpenCL Intercept Layer does not read from or write past the number of entries provided.